Merge branch '4.4' into 5.0

fabpot · fabpot · commit 254110c423a4 · 2020-03-18T08:16:55.000+01:00
* 4.4:
  [VarDumper] fix side-effect by not using mt_rand()
diff --git a/Cloner/VarCloner.php b/Cloner/VarCloner.php
@@ -45,7 +45,7 @@ protected function doClone($var)
                                         // or null if the original value is used directly
 
         if (!$gid = self::$gid) {
-            $gid = self::$gid = uniqid(mt_rand(), true); // Unique string used to detect the special $GLOBALS variable
+            $gid = self::$gid = md5(random_bytes(6)); // Unique string used to detect the special $GLOBALS variable
         }
         $arrayStub = new Stub();
         $arrayStub->type = Stub::TYPE_ARRAY;

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ protected function doClone($var)`
`45`	`45`	`// or null if the original value is used directly`
`46`	`46`
`47`	`47`	`if (!$gid = self::$gid) {`
`48`		`- $gid = self::$gid = uniqid(mt_rand(), true); // Unique string used to detect the special $GLOBALS variable`
	`48`	`+ $gid = self::$gid = md5(random_bytes(6)); // Unique string used to detect the special $GLOBALS variable`
`49`	`49`	`}`
`50`	`50`	`$arrayStub = new Stub();`
`51`	`51`	`$arrayStub->type = Stub::TYPE_ARRAY;`