Remove legacy code paths that rely on feature checks

Author: nicolas-grekas

Caster/SymfonyCaster.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\VarDumper\Caster;
 
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\Uid\TimeBasedUidInterface;
 use Symfony\Component\Uid\Ulid;
 use Symfony\Component\Uid\Uuid;
 use Symfony\Component\VarDumper\Cloner\Stub;
@@ -102,8 +103,7 @@ public static function castUuid(Uuid $uuid, array $a, Stub $stub, bool $isNested
         $a[Caster::PREFIX_VIRTUAL.'toBase58'] = $uuid->toBase58();
         $a[Caster::PREFIX_VIRTUAL.'toBase32'] = $uuid->toBase32();
 
-        // symfony/uid >= 5.3
-        if (method_exists($uuid, 'getDateTime')) {
+        if ($uuid instanceof TimeBasedUidInterface) {
             $a[Caster::PREFIX_VIRTUAL.'time'] = $uuid->getDateTime()->format('Y-m-d H:i:s.u \U\T\C');
         }
 
@@ -115,8 +115,7 @@ public static function castUlid(Ulid $ulid, array $a, Stub $stub, bool $isNested
         $a[Caster::PREFIX_VIRTUAL.'toBase58'] = $ulid->toBase58();
         $a[Caster::PREFIX_VIRTUAL.'toRfc4122'] = $ulid->toRfc4122();
 
-        // symfony/uid >= 5.3
-        if (method_exists($ulid, 'getDateTime')) {
+        if ($ulid instanceof TimeBasedUidInterface) {
             $a[Caster::PREFIX_VIRTUAL.'time'] = $ulid->getDateTime()->format('Y-m-d H:i:s.v \U\T\C');
         }
 

Tests/Caster/SymfonyCasterTest.php

@@ -34,49 +34,29 @@ public function testCastUuid()
         $this->assertDumpEquals($expectedDump, $uuid);
 
         $uuid = new UuidV6('1ebc50e9-8a23-6704-ad6f-59afd5cda7e5');
-        if (method_exists($uuid, 'getDateTime')) {
-            $expectedDump = <<<EODUMP
+        $expectedDump = <<<EODUMP
 Symfony\Component\Uid\UuidV6 {
   #uid: "1ebc50e9-8a23-6704-ad6f-59afd5cda7e5"
   toBase58: "4o8c5m6v4L8h5teww36JDa"
   toBase32: "0YQH8EK2H3CW2ATVTSNZAWV9Z5"
   time: "2021-06-04 08:26:44.591386 UTC"
 }
 EODUMP;
-        } else {
-            $expectedDump = <<<EODUMP
-Symfony\Component\Uid\UuidV6 {
-  #uid: "1ebc50e9-8a23-6704-ad6f-59afd5cda7e5"
-  toBase58: "4o8c5m6v4L8h5teww36JDa"
-  toBase32: "0YQH8EK2H3CW2ATVTSNZAWV9Z5"
-}
-EODUMP;
-        }
 
         $this->assertDumpEquals($expectedDump, $uuid);
     }
 
     public function testCastUlid()
     {
         $ulid = new Ulid('01F7B252SZQGTSQGYSGACASAW6');
-        if (method_exists($ulid, 'getDateTime')) {
-            $expectedDump = <<<EODUMP
+        $expectedDump = <<<EODUMP
 Symfony\Component\Uid\Ulid {
   #uid: "01F7B252SZQGTSQGYSGACASAW6"
   toBase58: "1Ba6pJPFWDwghSKFVvfQ1B"
   toRfc4122: "0179d622-8b3f-bc35-9bc3-d98298acab86"
   time: "2021-06-04 08:27:38.687 UTC"
 }
 EODUMP;
-        } else {
-            $expectedDump = <<<EODUMP
-Symfony\Component\Uid\Ulid {
-  #uid: "01F7B252SZQGTSQGYSGACASAW6"
-  toBase58: "1Ba6pJPFWDwghSKFVvfQ1B"
-  toRfc4122: "0179d622-8b3f-bc35-9bc3-d98298acab86"
-}
-EODUMP;
-        }
 
         $this->assertDumpEquals($expectedDump, $ulid);
     }

Tests/Dumper/CliDumperTest.php

@@ -515,10 +515,6 @@ public function testCollapse()
 
     public function testFileLinkFormat()
     {
-        if (!class_exists(FileLinkFormatter::class)) {
-            $this->markTestSkipped(\sprintf('Class "%s" is required to run this test.', FileLinkFormatter::class));
-        }
-
         $data = new Data([
             [
                 new ClassStub(self::class),