Use typed properties in tests as much as possible

Author: nicolas-grekas

Tests/Caster/CasterTest.php

@@ -22,7 +22,7 @@ class CasterTest extends TestCase
 {
     use VarDumperTestTrait;
 
-    private static $referenceArray = [
+    private static array $referenceArray = [
         'null' => null,
         'empty' => false,
         'public' => 'pub',

Tests/Caster/DateCasterTest.php

@@ -25,7 +25,7 @@ class DateCasterTest extends TestCase
 {
     use VarDumperTestTrait;
 
-    private $previousTimezone;
+    private string $previousTimezone;
 
     protected function setUp(): void
     {

Tests/Caster/RdKafkaCasterTest.php

@@ -30,8 +30,8 @@ class RdKafkaCasterTest extends TestCase
     private const TOPIC = 'test-topic';
     private const GROUP_ID = 'test-group-id';
 
-    private $hasBroker = false;
-    private $broker;
+    private bool $hasBroker = false;
+    private string $broker;
 
     protected function setUp(): void
     {

Tests/Caster/XmlReaderCasterTest.php

@@ -21,8 +21,7 @@ class XmlReaderCasterTest extends TestCase
 {
     use VarDumperTestTrait;
 
-    /** @var \XmlReader */
-    private $reader;
+    private \XmlReader $reader;
 
     protected function setUp(): void
     {

Tests/Command/Descriptor/CliDescriptorTest.php

@@ -20,8 +20,8 @@
 
 class CliDescriptorTest extends TestCase
 {
-    private static $timezone;
-    private static $prevTerminalEmulator;
+    private static string $timezone;
+    private static string|false $prevTerminalEmulator;
 
     public static function setUpBeforeClass(): void
     {

Tests/Command/Descriptor/HtmlDescriptorTest.php

@@ -19,7 +19,7 @@
 
 class HtmlDescriptorTest extends TestCase
 {
-    private static $timezone;
+    private static string $timezone;
 
     public static function setUpBeforeClass(): void
     {