replace uniqid() with random_bytes() to create identifiers

xabbuh · xabbuh · commit db0773813a55 · 2024-07-29T08:33:22.000+02:00
diff --git a/Command/Descriptor/HtmlDescriptor.php b/Command/Descriptor/HtmlDescriptor.php
@@ -50,7 +50,7 @@ public function describe(OutputInterface $output, Data $data, array $context, in
             $title = '<code>$ </code>'.$context['cli']['command_line'];
             $dedupIdentifier = $context['cli']['identifier'];
         } else {
-            $dedupIdentifier = uniqid('', true);
+            $dedupIdentifier = bin2hex(random_bytes(4));
         }
 
         $sourceDescription = '';

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function describe(OutputInterface $output, Data $data, array $context, in`
`50`	`50`	`$title = '<code>$ </code>'.$context['cli']['command_line'];`
`51`	`51`	`$dedupIdentifier = $context['cli']['identifier'];`
`52`	`52`	`} else {`
`53`		`- $dedupIdentifier = uniqid('', true);`
	`53`	`+ $dedupIdentifier = bin2hex(random_bytes(4));`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`$sourceDescription = '';`