Merge branch '4.4' into 5.1

xabbuh · xabbuh · commit de0072486e3c · 2020-09-09T10:28:14.000+02:00
* 4.4:
  [Intl] promote warnings to value errors on PHP 8
  Fix CS
  DateTime validator support for trailing data
  Remove some leftover for HHVM support
  Simplify code
  Fix tests on 5.6
  [Debug] Skip a test that was meant for HHVM.
  [Console] Silence warnings on sapi_windows_cp_set() call
  guard $argv + $token against null, preventing unnecessary exceptions
diff --git a/Tests/Caster/ReflectionCasterTest.php b/Tests/Caster/ReflectionCasterTest.php
@@ -84,9 +84,6 @@ public function testClosureCaster()
 
     public function testFromCallableClosureCaster()
     {
-        if (\defined('HHVM_VERSION_ID')) {
-            $this->markTestSkipped('Not for HHVM.');
-        }
         $var = [
             (new \ReflectionMethod($this, __FUNCTION__))->getClosure($this),
             (new \ReflectionMethod(__CLASS__, 'stub'))->getClosure(),

Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,6 @@ public function testClosureCaster()`
`84`	`84`
`85`	`85`	`public function testFromCallableClosureCaster()`
`86`	`86`	`{`
`87`		`- if (\defined('HHVM_VERSION_ID')) {`
`88`		`- $this->markTestSkipped('Not for HHVM.');`
`89`		`- }`
`90`	`87`	`$var = [`
`91`	`88`	`(new \ReflectionMethod($this, __FUNCTION__))->getClosure($this),`
`92`	`89`	`(new \ReflectionMethod(__CLASS__, 'stub'))->getClosure(),`