[VarDumper] fix truncating big arrays

nicolas-grekas · nicolas-grekas · commit ff25e5c732d2 · 2020-10-06T18:42:49.000+02:00
diff --git a/Cloner/VarCloner.php b/Cloner/VarCloner.php
@@ -247,7 +247,7 @@ protected function doClone($var)
                         $stub->position = $len++;
                     } elseif ($pos < $maxItems) {
                         if ($maxItems < $pos += \count($a)) {
-                            $a = \array_slice($a, 0, $maxItems - $pos);
+                            $a = \array_slice($a, 0, $maxItems - $pos, true);
                             if ($stub->cut >= 0) {
                                 $stub->cut += $pos - $maxItems;
                             }
diff --git a/Tests/Cloner/VarClonerTest.php b/Tests/Cloner/VarClonerTest.php
@@ -162,7 +162,7 @@ public function testLimits()
                     'Level 3 Item 3',
                 ],
                 [
-                    'Level 3 Item 4',
+                    999 => 'Level 3 Item 4',
                     'Level 3 Item 5',
                     'Level 3 Item 6',
                 ],
@@ -242,7 +242,7 @@ public function testLimits()
                     [1] => Array
                         (
                             [0] => 2
-                            [2] => 7
+                            [1] => 7
                         )
 
                     [2] => Array
@@ -299,7 +299,7 @@ public function testLimits()
 
             [7] => Array
                 (
-                    [0] => Level 3 Item 4
+                    [999] => Level 3 Item 4
                 )
 
         )

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ protected function doClone($var)`
`247`	`247`	`$stub->position = $len++;`
`248`	`248`	`} elseif ($pos < $maxItems) {`
`249`	`249`	`if ($maxItems < $pos += \count($a)) {`
`250`		`- $a = \array_slice($a, 0, $maxItems - $pos);`
	`250`	`+ $a = \array_slice($a, 0, $maxItems - $pos, true);`
`251`	`251`	`if ($stub->cut >= 0) {`
`252`	`252`	`$stub->cut += $pos - $maxItems;`
`253`	`253`	`}`