Absolute url for encore_entry_link_tags and encore_entry_script_tags

[dariogrd]

Hello,

I think it would be interesting if I could pass to encore_entry_link_tags and encore_entry_script_tags functions that I want to generate tags with absolute url. Now, if I want to get absolute url, I can't use encore_entry_link_tags and encore_entry_script_tags.

[benr77]

+1 for this. I'm generating PDF documents, and the CSS is broken due to the asset URLs being relative instead of absolute.

[dariogrd]

yes, I also need absolute url for generating PDFs

[NullIsNot0]

Read the last part of README.md file:

If you want more control, you can use the encore_entry_js_files() and encore_entry_css_files() methods to get the list of files needed, then loop and create the script and link tags manually.

Of course, it would be better if encore_entry_link_tags() and encore_entry_script_tags provided functionality to generate relative or absolute paths, but the solution above is a workaround for now.

[taner-dll]

need for generating PDFs.

[weaverryan]

Hmm, yes, I think this feature makes sense. Probably I would recommend 2 new functions:

• encore_absolute_entry_link_tags
• encore_absolute_entry_script_tags

I believe we would just need to use the request_stack to fetch the master request then prefix the paths with $request->getSchemeAndHttpHost() (if they are not already absolute). For reference, I'm looking how this works for absolute_url() (https://github.com/symfony/symfony/blob/5aa0967f9f0ab803ededefb040d48a0ebc7a27a6/src/Symfony/Bridge/Twig/Extension/HttpFoundationExtension.php#L58) - but the vast majority of that doesn't apply (we can expect that there is a master request, and we know the URLs, for example, will have a starting / by the time they get this far.

[MrMitch]

I'm also in favor of that. My use case is the same as @benr77, i'm generating PDF files from HTML files and the pdf generator (https://github.com/GoogleChrome/puppeteer) needs absolute urls to proprely load the stylesheets.

I was about to create an issue on the symfony/webpack-encore when i remembered that the encore_entry_*_tags are provided by this bundle and not webpack-encore itself.

At the moment, i'm working around this by using a custom macro that relies on the encore_entry_*_files, asset and absolute_url functions :

{% macro encore_absolute_link_tags(entry_point) %}
    {% for file in encore_entry_css_files(entry_point) %}
        <link href="{{ absolute_url(asset(file)) }}" rel="stylesheet" />
    {% endfor %}
{% endmacro %}

(I see @weaverryan and I had the same idea regarding the naming)

This only works for stylesheets (my only need so-far) but another macro with the same logic could be added to also support absolute urls for <script> tags.

Havign this built-into the bundle would be really great !

[firomero]

this macro is not working to me, it doesn't return the files. Maybe the version I am using. Symfony4.2 trying to deploy on Apache. There is another way?

[MrMitch]

@firomero this is likely because you already use the entry_entry_*_files functions elsewhere before.
Take a look at #33 which explains this situation in a bit more details.

[max4kaps]

same here.
@MrMitch: I used your code.

Did a trick for me. Hier is addition for scripts:

{% macro encore_absolute_link_tags(entry_point) %}
    {% for file in encore_entry_css_files(entry_point) %}
        <link href="{{ absolute_url(asset(file)) }}" rel="stylesheet" />
    {% endfor %}
{% endmacro %}

{% macro encore_absolute_script_tags(entry_point) %}
    {% for file in encore_entry_js_files(entry_point) %}
        <script src="{{ absolute_url(asset(file)) }}" ></script>
    {% endfor %}
{% endmacro %}```

[poolerMF]

+1

[victorGI]

+1

[Surf-N-Code]

+1

[crabnky]

+1 (first in 2020) :)