Removing unnecessary enabled options

Author: weaverryan

index.js

@@ -221,35 +221,32 @@ module.exports = {
      *
      * https://github.com/postcss/postcss-loader
      *
-     * @param {boolean} enabled
      * @return {exports}
      */
-    enablePostCssLoader(enabled = true) {
-        webpackConfig.enablePostCssLoader(enabled);
+    enablePostCssLoader() {
+        webpackConfig.enablePostCssLoader();
 
         return this;
     },
 
     /**
      * Call this if you plan on loading SASS files.
      *
-     * @param {boolean} enabled
      * @return {exports}
      */
-    enableSassLoader(enabled = true) {
-        webpackConfig.enableSassLoader(enabled);
+    enableSassLoader() {
+        webpackConfig.enableSassLoader();
 
         return this;
     },
 
     /**
      * Call this if you plan on loading less files.
      *
-     * @param {boolean} enabled
      * @return {exports}
      */
-    enableLessLoader(enabled = true) {
-        webpackConfig.enableLessLoader(enabled);
+    enableLessLoader() {
+        webpackConfig.enableLessLoader();
 
         return this;
     },
@@ -276,11 +273,10 @@ module.exports = {
      * If enabled, the react preset is added to Babel:
      * https://babeljs.io/docs/plugins/preset-react/
      *
-     * @param {boolean} enabled
      * @returns {exports}
      */
-    enableReactPreset(enabled = true) {
-        webpackConfig.enableReactPreset(enabled);
+    enableReactPreset() {
+        webpackConfig.enableReactPreset();
 
         return this;
     },

lib/WebpackConfig.js

@@ -185,20 +185,20 @@ class WebpackConfig {
         this.addEntry(name, files);
     }
 
-    enablePostCssLoader(enabled = true) {
-        this.usePostCssLoader = enabled;
+    enablePostCssLoader() {
+        this.usePostCssLoader = true;
     }
 
-    enableSassLoader(enabled = true) {
-        this.useSassLoader = enabled;
+    enableSassLoader() {
+        this.useSassLoader = true;
     }
 
-    enableLessLoader(enabled = true) {
-        this.useLessLoader = enabled;
+    enableLessLoader() {
+        this.useLessLoader = true;
     }
 
-    enableReactPreset(enabled = true) {
-        this.useReact = enabled;
+    enableReactPreset() {
+        this.useReact = true;
     }
 
     cleanupOutputBeforeBuild() {

test/config-generator.js

@@ -257,19 +257,19 @@ describe('The config-generator function', () => {
     });
 
     describe('enablePostCssLoader() adds the postcss-loader', () => {
-        it('enablePostCssLoader(false)', () => {
+        it('without enablePostCssLoader()', () => {
             const config = createConfig();
             config.outputPath = '/tmp/output/public-path';
             config.publicPath = '/public-path';
             config.addEntry('main', './main');
-            config.enablePostCssLoader(false);
+            //config.enablePostCssLoader();
 
             const actualConfig = configGenerator(config);
 
             expect(JSON.stringify(actualConfig.module.rules)).to.not.contain('postcss-loader');
         });
 
-        it('enablePostCssLoader(true)', () => {
+        it('enablePostCssLoader()', () => {
             const config = createConfig();
             config.outputPath = '/tmp/output/public-path';
             config.publicPath = '/public-path';
@@ -283,19 +283,19 @@ describe('The config-generator function', () => {
     });
 
     describe('enableSassLoader() adds the sass-loader', () => {
-        it('enableSassLoader(false)', () => {
+        it('without enableSassLoader()', () => {
             const config = createConfig();
             config.outputPath = '/tmp/output/public-path';
             config.publicPath = '/public-path';
             config.addEntry('main', './main');
-            config.enableSassLoader(false);
+            // config.enableSassLoader();
 
             const actualConfig = configGenerator(config);
 
             expect(JSON.stringify(actualConfig.module.rules)).to.not.contain('sass-loader');
         });
 
-        it('enableSassLoader(true)', () => {
+        it('enableSassLoader()', () => {
             const config = createConfig();
             config.outputPath = '/tmp/output/public-path';
             config.publicPath = '/public-path';
@@ -309,19 +309,19 @@ describe('The config-generator function', () => {
     });
 
     describe('enableLessLoader() adds the less-loader', () => {
-        it('enableLessLoader(false)', () => {
+        it('without enableLessLoader()', () => {
             const config = createConfig();
             config.outputPath = '/tmp/output/public-path';
             config.publicPath = '/public-path';
             config.addEntry('main', './main');
-            config.enableLessLoader(false);
+            // do not enable the less loader
 
             const actualConfig = configGenerator(config);
 
             expect(JSON.stringify(actualConfig.module.rules)).to.not.contain('less-loader');
         });
 
-        it('enableLessLoader(true)', () => {
+        it('enableLessLoader()', () => {
             const config = createConfig();
             config.outputPath = '/tmp/output/public-path';
             config.publicPath = '/public-path';