Skip to content

Commit 1acc67a

Browse files
committed
Changing | to ||, which is the correct format
1 parent d7cf989 commit 1acc67a

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

lib/package-helper.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ function getInstallCommand(packageConfigs) {
4040
return packageConfig.name;
4141
}
4242

43-
// e.g. ^4.0|^5.0: use the latest version
43+
// e.g. ^4.0||^5.0: use the latest version
4444
let recommendedVersion = packageConfig.version;
45-
if (recommendedVersion.indexOf('|') !== -1) {
46-
recommendedVersion = recommendedVersion.split('|').pop();
45+
if (recommendedVersion.indexOf('||') !== -1) {
46+
recommendedVersion = recommendedVersion.split('|').pop().trim();
4747
}
4848

4949
// recommend the version included in our package.json file

test/package-helper.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,17 @@ describe('package-helper', () => {
7474
});
7575

7676
it('Recommends correct install with a more complex constraint', () => {
77-
// e.g. ^7.0|^8.0
7877
const packageRecommendations = packageHelper.getMissingPackageRecommendations([
79-
{ name: 'foo', version: '^7.0|^8.0' },
78+
{ name: 'foo', version: '^7.0||^8.0' },
79+
{ name: 'bar' }
80+
]);
81+
82+
expect(packageRecommendations.installCommand).to.contain('yarn add foo@^8.0 bar');
83+
});
84+
85+
it('Recommends correct install with a more complex constraint', () => {
86+
const packageRecommendations = packageHelper.getMissingPackageRecommendations([
87+
{ name: 'foo', version: '^7.0 || ^8.0' },
8088
{ name: 'bar' }
8189
]);
8290

0 commit comments

Comments
 (0)