Adding Encore.splitEntryChunks() to enable that new feature easier

Author: weaverryan

index.js

@@ -404,13 +404,35 @@ class Encore {
         return this;
     }
 
+    /**
+     * Tell Webpack to "split" your entry chunks.
+     *
+     * This will mean that, instead of adding 1 script tag
+     * to your page, your server-side code will need to read
+     * the entrypoints.json file in the build directory to
+     * determine the *multiple* .js (and .css) files that
+     * should be included for each entry.
+     *
+     * This is a performance optimization, but requires extra
+     * work (described above) to support this.
+     *
+     * @returns {Encore}
+     */
+    splitEntryChunks() {
+        webpackConfig.splitEntryChunks();
+
+        return this;
+    }
+
     /**
      * Configure the optimization.splitChunks configuration.
      *
      * https://webpack.js.org/plugins/split-chunks-plugin/
      *
      * Encore.configureSplitChunks(function(splitChunks) {
      *      // change the configuration
+     *
+     *      splitChunks.minSize = 0;
      * });
      *
      * @param {function} callback

lib/WebpackConfig.js

@@ -87,6 +87,7 @@ class WebpackConfig {
         this.stylusLoaderOptionsCallback = () => {};
         this.babelConfigurationCallback = () => {};
         this.cssLoaderConfigurationCallback = () => {};
+        this.shouldSplitEntryChunks = false;
         this.splitChunksConfigurationCallback = () => {};
         this.vueLoaderOptionsCallback = () => {};
         this.eslintLoaderOptionsCallback = () => {};
@@ -319,6 +320,10 @@ class WebpackConfig {
         this.cssLoaderConfigurationCallback = callback;
     }
 
+    splitEntryChunks() {
+        this.shouldSplitEntryChunks = true;
+    }
+
     configureSplitChunks(callback) {
         if (typeof callback !== 'function') {
             throw new Error('Argument 1 to configureSplitChunks() must be a callback function.');

lib/config-generator.js

@@ -361,7 +361,9 @@ class ConfigGenerator {
             optimization.namedModules = true;
         }
 
-        let splitChunks = {};
+        let splitChunks = {
+            chunks: this.webpackConfig.shouldSplitEntryChunks ? 'all' : 'async'
+        };
         if (this.webpackConfig.sharedCommonsEntryName) {
             const cacheGroups = {};
             cacheGroups[this.webpackConfig.sharedCommonsEntryName] = {

test/functional.js

@@ -1249,8 +1249,8 @@ module.exports = {
                 config.setPublicPath('/build');
                 // enable versioning to make sure entrypoints.json is not affected
                 config.enableVersioning();
+                config.splitEntryChunks();
                 config.configureSplitChunks((splitChunks) => {
-                    splitChunks.chunks = 'all';
                     splitChunks.minSize = 0;
                 });
 

test/index.js

@@ -134,6 +134,15 @@ describe('Public API', () => {
 
     });
 
+    describe('splitEntryChunks', () => {
+
+        it('must return the API object', () => {
+            const returnedValue = api.splitEntryChunks();
+            expect(returnedValue).to.equal(api);
+        });
+
+    });
+
     describe('configureSplitChunks', () => {
 
         it('must return the API object', () => {