preventing shared entry & split chunks from being used together

Author: weaverryan

lib/WebpackConfig.js

@@ -326,6 +326,10 @@ class WebpackConfig {
     }
 
     splitEntryChunks() {
+        if (this.sharedCommonsEntryName) {
+            throw new Error('Using splitEntryChunks() and createSharedEntry() together is not supported. Use one of these strategies only to optimize your build.');
+        }
+
         this.shouldSplitEntryChunks = true;
     }
 
@@ -338,6 +342,10 @@ class WebpackConfig {
     }
 
     createSharedEntry(name, file) {
+        if (this.shouldSplitEntryChunks) {
+            throw new Error('Using splitEntryChunks() and createSharedEntry() together is not supported. Use one of these strategies only to optimize your build.');
+        }
+
         // don't allow to call this twice
         if (this.sharedCommonsEntryName) {
             throw new Error('createSharedEntry() cannot be called multiple times: you can only create *one* shared entry.');

test/WebpackConfig.js

@@ -348,6 +348,15 @@ describe('WebpackConfig object', () => {
                 config.createSharedEntry('vendor2', './main');
             }).to.throw('cannot be called multiple');
         });
+
+        it('Calling with splitEntryChunks() is not supported', () => {
+            const config = createConfig();
+            config.splitEntryChunks();
+
+            expect(() => {
+                config.createSharedEntry('vendor', './main');
+            }).to.throw('together is not supported');
+        });
     });
 
     describe('autoProvideVariables', () => {
@@ -451,6 +460,15 @@ describe('WebpackConfig object', () => {
                 config.configureSplitChunks('FOO');
             }).to.throw('must be a callback function');
         });
+
+        it('Calling with createdSharedEntry() is not supported', () => {
+            const config = createConfig();
+            config.createSharedEntry('vendor', './main');
+
+            expect(() => {
+                config.splitEntryChunks();
+            }).to.throw('together is not supported');
+        });
     });
 
     describe('enablePostCssLoader', () => {