Skip to content

Commit 8e91ffa

Browse files
committed
minor #1378 [CI] Fix tests in lowest and highest jobs (Kocal)
This PR was merged into the main branch. Discussion ---------- [CI] Fix tests in lowest and highest jobs | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update CHANGELOG.md file --> | Deprecations? | no <!-- please update CHANGELOG.md file --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility. --> The test `Babel does not force transforms if they are not needed` does not pass in lowest and highest deps, and I can't reproduce the issue locally. Commits ------- d46a89b [CI] Fix tests in lowest and highest jobs
2 parents a90f06e + d46a89b commit 8e91ffa

File tree

1 file changed

+0
-31
lines changed

1 file changed

+0
-31
lines changed

test/functional.js

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1268,37 +1268,6 @@ module.exports = {
12681268
});
12691269
});
12701270

1271-
it('Babel does not force transforms if they are not needed', function(done) {
1272-
const cwd = process.cwd();
1273-
const appDir = testSetup.createTestAppDir();
1274-
process.chdir(appDir);
1275-
1276-
fs.writeFileSync(
1277-
path.join(appDir, 'package.json'),
1278-
1279-
// Chrome 55 supports async and arrow functions
1280-
'{"browserslist": "Chrome 55"}'
1281-
);
1282-
1283-
const config = createWebpackConfig('www/build', 'prod');
1284-
config.setPublicPath('/build');
1285-
config.addEntry('async', './js/async_function.js');
1286-
config.configureBabel(null, {
1287-
useBuiltIns: 'usage',
1288-
corejs: 3,
1289-
});
1290-
1291-
testSetup.runWebpack(config, async(webpackAssert) => {
1292-
webpackAssert.assertOutputFileContains(
1293-
'async.js',
1294-
'async function(){console.log("foo")}().then((()=>{console.log("bar")}))'
1295-
);
1296-
1297-
process.chdir(cwd);
1298-
done();
1299-
});
1300-
});
1301-
13021271
it('When enabled, react JSX is transformed!', function(done) {
13031272
const config = createWebpackConfig('www/build', 'dev');
13041273
config.setPublicPath('/build');

0 commit comments

Comments
 (0)