Skip to content

Commit 9202ae5

Browse files
committed
bug #414 Fix entries disappearing from the manifest when using --watch (Lyrkan)
This PR was merged into the master branch. Discussion ---------- Fix entries disappearing from the manifest when using --watch This PR should fix #413. When using `--watch` the first build works fine (unless you're using a recent version of `mini-css-extract-plugin`... but that's another story :)), but the next ones don't include all the assets. Based on a few tests I made it could be related to shellscape/webpack-manifest-plugin#144 but that issue won't be fixed until the next major version of WebpackManifestPlugin (3.x). Since the workaround (setting the `seed` option to `{}`) seems to be working fine I suggest that we add it to the default options that are passed to the plugin. Commits ------- bd2e583 Set the seed option of the WebpackManifestPlugin to fix watch mode
2 parents eedc8ca + bd2e583 commit 9202ae5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/plugins/manifest.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const manifestKeyPrefixHelper = require('../utils/manifest-key-prefix-helper');
2222
*/
2323
module.exports = function(plugins, webpackConfig) {
2424
const manifestPluginOptions = {
25+
seed: {},
2526
basePath: manifestKeyPrefixHelper(webpackConfig),
2627
// always write a manifest.json file, even with webpack-dev-server
2728
writeToFileEmit: true,

0 commit comments

Comments
 (0)