debug

Author: Kocal

test/bin/encore.test.js

@@ -308,27 +308,18 @@ module.exports = Encore.getWebpackConfig();
             );
 
             const binPath = path.resolve(projectDir, 'bin', 'encore.js');
-            try {
-                 await execAsync(`node ${binPath} dev-server --context=${testDir}`, {
-                    cwd: testDir,
-                    env: Object.assign({}, process.env, { NO_COLOR: 'true' })
-                });
-
-                throw new Error('Expected command to fail.');
-            } catch (err) {
-                console.log({ err })
-                if (!'stdout' in err || !'stderr' in err) {
-                    throw new Error(`Error executing encore: ${err}`);
-                }
+             const { stdout, stderr } = await execAsync(`node ${binPath} dev-server --context=${testDir}`, {
+                cwd: testDir,
+                env: Object.assign({}, process.env, { NO_COLOR: 'true' })
+            });
 
-                expect(err.stdout).to.contain('Install webpack-dev-server to use the webpack Development Server');
-                expect(err.stdout).to.contain('npm install webpack-dev-server --save-dev');
-                expect(err.stderr).to.equal('');
+            expect(stdout).to.contain('Install webpack-dev-server to use the webpack Development Server');
+            expect(stdout).to.contain('npm install webpack-dev-server --save-dev');
+            expect(stderr).to.equal('');
 
-                expect(err.stdout).not.to.contain('Running webpack-dev-server ...');
-                expect(err.stdout).not.to.contain('Compiled successfully in');
-                expect(err.stdout).not.to.contain('webpack compiled successfully');
-            }
+            expect(stdout).not.to.contain('Running webpack-dev-server ...');
+            expect(stdout).not.to.contain('Compiled successfully in');
+            expect(stdout).not.to.contain('webpack compiled successfully');
         });
     });
 });

test/config-generator.test.js

@@ -965,14 +965,16 @@ describe('The config-generator function', () => {
     });
 
     describe('Test shouldSplitEntryChunks', () => {
-        const config = createConfig();
-        config.outputPath = '/tmp/public/build';
-        config.setPublicPath('/build/');
-        config.splitEntryChunks();
-
-        const actualConfig = configGenerator(config);
-        expect(actualConfig.optimization.splitChunks.chunks).to.equal('all');
-        expect(actualConfig.optimization.splitChunks.name).to.be.undefined;
+        it('with defaults', () => {
+            const config = createConfig();
+            config.outputPath = '/tmp/public/build';
+            config.setPublicPath('/build/');
+            config.splitEntryChunks();
+
+            const actualConfig = configGenerator(config);
+            expect(actualConfig.optimization.splitChunks.chunks).to.equal('all');
+            expect(actualConfig.optimization.splitChunks.name).to.be.undefined;
+        })
     });
 
     describe('Test shouldUseSingleRuntimeChunk', () => {

test/functional.test.js

@@ -77,11 +77,13 @@ describe('Functional tests using webpack', { timeout: 10000}, function() {
     let browser;
 
     beforeAll(async () => {
+        console.log('beforeAll', puppeteer);
         browser = await puppeteer.launch()
-    });
 
-    afterAll(async() => {
-        await browser.close()
+        return async() => {
+            console.log('closeBrowser', browser);
+            await browser.close();
+        }
     });
 
     describe('Basic scenarios.', () => {
@@ -1393,7 +1395,6 @@ module.exports = {
         });
 
         it('TypeScript is compiled and type checking is done in a separate process!', (done) => {
-            this.timeout(10000);
             setTimeout(done, 9000);
 
             const config = createWebpackConfig('www/build', 'dev');