Omitting the _tmp_shared from the manifest & entrypoints files

Author: weaverryan

lib/config-generator.js

@@ -40,6 +40,7 @@ const notifierPluginUtil = require('./plugins/notifier');
 const sharedEntryConcatPuginUtil = require('./plugins/shared-entry-concat');
 const PluginPriorities = require('./plugins/plugin-priorities');
 const applyOptionsCallback = require('./utils/apply-options-callback');
+const sharedEntryTmpName = require('./utils/sharedEntryTmpName');
 const tmp = require('tmp');
 const fs = require('fs');
 const path = require('path');
@@ -133,7 +134,7 @@ class ConfigGenerator {
                 `require('${path.resolve(this.webpackConfig.getContext(), this.webpackConfig.sharedCommonsEntryFile)}')`
             );
 
-            entry._tmp_shared = tmpFileObject.name;
+            entry[sharedEntryTmpName] = tmpFileObject.name;
         }
 
         return entry;

lib/plugins/entry-files-manifest.js

@@ -12,6 +12,7 @@
 const EntryFilesManifestPlugin = require('../webpack/entry-files-manifest-plugin');
 const PluginPriorities = require('./plugin-priorities');
 const path = require('path');
+const sharedEntryTmpName = require('../utils/sharedEntryTmpName');
 
 /**
  * @param {Array} plugins
@@ -22,7 +23,8 @@ module.exports = function(plugins, webpackConfig) {
 
     plugins.push({
         plugin: new EntryFilesManifestPlugin(
-            path.join(webpackConfig.outputPath, 'entrypoints.json')
+            path.join(webpackConfig.outputPath, 'entrypoints.json'),
+            [sharedEntryTmpName]
         ),
         priority: PluginPriorities.DeleteUnusedEntriesJSPlugin
     });

lib/plugins/manifest.js

@@ -12,6 +12,7 @@
 const ManifestPlugin = require('webpack-manifest-plugin');
 const PluginPriorities = require('./plugin-priorities');
 const applyOptionsCallback = require('../utils/apply-options-callback');
+const sharedEntryTmpName = require('../utils/sharedEntryTmpName');
 
 /**
  * @param {Array} plugins
@@ -30,6 +31,9 @@ module.exports = function(plugins, webpackConfig) {
         basePath: manifestPrefix,
         // always write a manifest.json file, even with webpack-dev-server
         writeToFileEmit: true,
+        filter: (file) => {
+            return (!file.isChunk || file.chunk.id !== sharedEntryTmpName);
+        }
     };
 
     plugins.push({

lib/utils/sharedEntryTmpName.js

@@ -0,0 +1,12 @@
+/*
+ * This file is part of the Symfony Webpack Encore package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+'use strict';
+
+module.exports = '_tmp_shared';

lib/webpack/entry-files-manifest-plugin.js

@@ -12,8 +12,9 @@
 const logger = require('../logger');
 const fse = require('fs-extra');
 
-function EntryFilesManifestPlugin(manifestFilename = []) {
+function EntryFilesManifestPlugin(manifestFilename, entryNamesToSkip) {
     this.manifestFilename = manifestFilename;
+    this.entryNamesToSkip = entryNamesToSkip;
 }
 
 /**
@@ -42,6 +43,10 @@ EntryFilesManifestPlugin.prototype.apply = function(compiler) {
     const done = (stats) => {
         const entrypoints = {};
         stats.compilation.entrypoints.forEach((entry, entryName) => {
+            if (this.entryNamesToSkip.includes(entryName)) {
+                return;
+            }
+
             const { cssFiles, jsFiles } = extractFiles(entry);
             entrypoints[entryName] = {
                 js: jsFiles,

lib/webpack/shared-entry-concat-plugin.js

@@ -11,6 +11,7 @@
 
 const fs = require('fs');
 const path = require('path');
+const sharedEntryTmpName = require('../utils/sharedEntryTmpName');
 
 function SharedEntryConcatPlugin(sharedEntryName, buildDir) {
     this.sharedEntryName = sharedEntryName;
@@ -41,7 +42,7 @@ SharedEntryConcatPlugin.prototype.apply = function(compiler) {
          */
 
         const sharedEntryOutputFile = path.join(this.buildDir, this.sharedEntryName + '.js');
-        const tmpEntryBootstrapFile = path.join(this.buildDir, '_tmp_shared.js');
+        const tmpEntryBootstrapFile = path.join(this.buildDir, sharedEntryTmpName + '.js');
 
         if (!fs.existsSync(sharedEntryOutputFile)) {
             throw new Error(`Could not find shared entry output file: ${sharedEntryOutputFile}`);

test/functional.js

@@ -15,6 +15,7 @@ const expect = chai.expect;
 const path = require('path');
 const testSetup = require('./helpers/setup');
 const fs = require('fs-extra');
+const sharedEntryTmpName = require('../lib/utils/sharedEntryTmpName');
 
 function createWebpackConfig(outputDirName = '', command, argv = {}) {
     return testSetup.createWebpackConfig(
@@ -645,6 +646,12 @@ describe('Functional tests using webpack', function() {
                     'function __webpack_require__'
                 );
 
+                // make sure the _tmp_shared entry does not live in the manifest
+                webpackAssert.assertManifestPathDoesNotExist(
+                    sharedEntryTmpName + '.js'
+                );
+                webpackAssert.assertOutputFileDoesNotContain('entrypoints.json', sharedEntryTmpName);
+
                 testSetup.requestTestPage(
                     path.join(config.getContext(), 'www'),
                     [