Skip to content

Commit e5112e5

Browse files
committed
feature #1382 Re-add webpack-manifest-plugin dependency, which was previously embedded in #921 (Kocal)
This PR was merged into the main branch. Discussion ---------- Re-add `webpack-manifest-plugin` dependency, which was previously embedded in #921 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update CHANGELOG.md file --> | Deprecations? | no <!-- please update CHANGELOG.md file --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility. --> While working on #1381, I noticed that `lib/webpack-manifest-plugin/` was https://github.com/shellscape/webpack-manifest-plugin embedded with fix shellscape/webpack-manifest-plugin#249 The package was embedded because it was possible for the upstream PR to never be merged, but it has been merged and released. We should not have any BCs from https://github.com/shellscape/webpack-manifest-plugin/releases Commits ------- d5d6b7b Re-add webpack-manifest-plugin as a dependency
2 parents 1a2e5ef + d5d6b7b commit e5112e5

File tree

12 files changed

+32
-389
lines changed

12 files changed

+32
-389
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
If you manually specified the option `insert`, now it can only be a selector or the path to the module.
1212
Follow the [style-loader migration guide](https://github.com/webpack-contrib/style-loader/releases/tag/v4.0.0) to upgrade!
1313

14+
* Re-add `webpack-manifest-plugin` dependency, which was previously embedded in https://github.com/symfony/webpack-encore/pull/921
15+
1416
## 5.1.0
1517

1618
### Features

eslint.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ module.exports = [
3030
...globals.node,
3131
},
3232
},
33-
ignores: ['lib/webpack-manifest-plugin']
3433
},
3534
{
3635
'rules': {

lib/plugins/manifest.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* @import WebpackConfig from '../WebpackConfig'
1414
*/
1515

16-
const { WebpackManifestPlugin } = require('../webpack-manifest-plugin');
16+
const { WebpackManifestPlugin } = require('webpack-manifest-plugin');
1717
const PluginPriorities = require('./plugin-priorities');
1818
const applyOptionsCallback = require('../utils/apply-options-callback');
1919
const copyEntryTmpName = require('../utils/copyEntryTmpName');

lib/webpack-manifest-plugin/LICENSE

Lines changed: 0 additions & 21 deletions
This file was deleted.

lib/webpack-manifest-plugin/README.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

lib/webpack-manifest-plugin/helpers.js

Lines changed: 0 additions & 123 deletions
This file was deleted.

lib/webpack-manifest-plugin/hooks.js

Lines changed: 0 additions & 154 deletions
This file was deleted.

0 commit comments

Comments
 (0)