Fixing a bug where runtime.js would appear for "style" entries in

entrypoints.json

Author: weaverryan

lib/plugins/entry-files-manifest.js

@@ -24,7 +24,8 @@ module.exports = function(plugins, webpackConfig) {
     plugins.push({
         plugin: new EntryFilesManifestPlugin(
             path.join(webpackConfig.outputPath, 'entrypoints.json'),
-            [sharedEntryTmpName]
+            [sharedEntryTmpName],
+            webpackConfig.styleEntries
         ),
         priority: PluginPriorities.DeleteUnusedEntriesJSPlugin
     });

lib/webpack/entry-files-manifest-plugin.js

@@ -12,9 +12,10 @@
 const logger = require('../logger');
 const fse = require('fs-extra');
 
-function EntryFilesManifestPlugin(manifestFilename, entryNamesToSkip) {
+function EntryFilesManifestPlugin(manifestFilename, entryNamesToSkip, styleEntriesMap) {
     this.manifestFilename = manifestFilename;
     this.entryNamesToSkip = entryNamesToSkip;
+    this.styleEntriesMap = styleEntriesMap;
 }
 
 /**
@@ -61,11 +62,18 @@ EntryFilesManifestPlugin.prototype.apply = function(compiler) {
                 return;
             }
 
-            const { cssChunkIds, jsChunkIds } = extractChunkIds(entry);
+            let { cssChunkIds, jsChunkIds } = extractChunkIds(entry);
+
+            // for style entries, there are no js files
+            // this makes sure runtime.js is not included
+            if (this.styleEntriesMap.has(entryName)) {
+                jsChunkIds = [];
+            }
 
             // look up the original chunk name by id
             const cssChunkNames = cssChunkIds.map(chunkId => getChunkNameFromId(stats.compilation.chunks, chunkId));
             const jsChunkNames = jsChunkIds.map(chunkId => getChunkNameFromId(stats.compilation.chunks, chunkId));
+
             const cssFiles = convertChunkNamesToFilenames(cssChunkNames, 'css');
             const jsFiles = convertChunkNamesToFilenames(jsChunkNames, 'js');