minor #42118 [Yaml] Add types to private properties (derrabus)

This PR was merged into the 6.0 branch.

Discussion
----------

[Yaml] Add types to private properties

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

40688504ac [Yaml] Add types to private properties

Author: nicolas-grekas

Command/LintCommand.php

@@ -35,18 +35,18 @@ class LintCommand extends Command
     protected static $defaultName = 'lint:yaml';
     protected static $defaultDescription = 'Lint a YAML file and outputs encountered errors';
 
-    private $parser;
-    private $format;
-    private $displayCorrectFiles;
-    private $directoryIteratorProvider;
-    private $isReadableProvider;
+    private Parser $parser;
+    private ?string $format = null;
+    private bool $displayCorrectFiles;
+    private ?\Closure $directoryIteratorProvider;
+    private ?\Closure $isReadableProvider;
 
     public function __construct(string $name = null, callable $directoryIteratorProvider = null, callable $isReadableProvider = null)
     {
         parent::__construct($name);
 
-        $this->directoryIteratorProvider = $directoryIteratorProvider;
-        $this->isReadableProvider = $isReadableProvider;
+        $this->directoryIteratorProvider = null === $directoryIteratorProvider || $directoryIteratorProvider instanceof \Closure ? $directoryIteratorProvider : \Closure::fromCallable($directoryIteratorProvider);
+        $this->isReadableProvider = null === $isReadableProvider || $isReadableProvider instanceof \Closure ? $isReadableProvider : \Closure::fromCallable($isReadableProvider);
     }
 
     /**
@@ -232,11 +232,7 @@ private function getFiles(string $fileOrDirectory): iterable
 
     private function getParser(): Parser
     {
-        if (!$this->parser) {
-            $this->parser = new Parser();
-        }
-
-        return $this->parser;
+        return $this->parser ??= new Parser();
     }
 
     private function getDirectoryIterator(string $directory): iterable

Exception/ParseException.php

@@ -18,10 +18,10 @@
  */
 class ParseException extends RuntimeException
 {
-    private $parsedFile;
-    private $parsedLine;
-    private $snippet;
-    private $rawMessage;
+    private ?string $parsedFile;
+    private int $parsedLine;
+    private ?string $snippet;
+    private string $rawMessage;
 
     /**
      * @param string      $message    The error message

Inline.php

@@ -29,10 +29,10 @@ class Inline
     public static $parsedLineNumber = -1;
     public static $parsedFilename;
 
-    private static $exceptionOnInvalidType = false;
-    private static $objectSupport = false;
-    private static $objectForMap = false;
-    private static $constantSupport = false;
+    private static bool $exceptionOnInvalidType = false;
+    private static bool $objectSupport = false;
+    private static bool $objectForMap = false;
+    private static bool $constantSupport = false;
 
     public static function initialize(int $flags, int $parsedLineNumber = null, string $parsedFilename = null)
     {
@@ -50,9 +50,9 @@ public static function initialize(int $flags, int $parsedLineNumber = null, stri
     /**
      * Converts a YAML string to a PHP value.
      *
-     * @param string $value      A YAML string
-     * @param int    $flags      A bit field of PARSE_* constants to customize the YAML parser behavior
-     * @param array  $references Mapping of variable names to values
+     * @param string|null $value      A YAML string
+     * @param int         $flags      A bit field of PARSE_* constants to customize the YAML parser behavior
+     * @param array       $references Mapping of variable names to values
      *
      * @throws ParseException
      */

Parser.php

@@ -27,17 +27,17 @@ class Parser
     public const BLOCK_SCALAR_HEADER_PATTERN = '(?P<separator>\||>)(?P<modifiers>\+|\-|\d+|\+\d+|\-\d+|\d+\+|\d+\-)?(?P<comments> +#.*)?';
     public const REFERENCE_PATTERN = '#^&(?P<ref>[^ ]++) *+(?P<value>.*)#u';
 
-    private $filename;
-    private $offset = 0;
-    private $numberOfParsedLines = 0;
-    private $totalNumberOfLines;
-    private $lines = [];
-    private $currentLineNb = -1;
-    private $currentLine = '';
-    private $refs = [];
-    private $skippedLineNumbers = [];
-    private $locallySkippedLineNumbers = [];
-    private $refsBeingParsed = [];
+    private ?string $filename = null;
+    private int $offset = 0;
+    private int $numberOfParsedLines = 0;
+    private ?int $totalNumberOfLines = null;
+    private array $lines = [];
+    private int $currentLineNb = -1;
+    private string $currentLine = '';
+    private array $refs = [];
+    private array $skippedLineNumbers = [];
+    private array $locallySkippedLineNumbers = [];
+    private array $refsBeingParsed = [];
 
     /**
      * Parses a YAML file into a PHP value.

Tag/TaggedValue.php

@@ -17,8 +17,8 @@
  */
 final class TaggedValue
 {
-    private $tag;
-    private $value;
+    private string $tag;
+    private mixed $value;
 
     public function __construct(string $tag, mixed $value)
     {