bug symfony#49223 [WebProfilerBundle] Fix some minor HTML issues (javiereguiluz)

fabpot · fabpot · commit 00676bc161cf · 2023-02-04T09:11:41.000+01:00
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [WebProfilerBundle] Fix some minor HTML issues | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In symfony#49205 we're fixing deprecations, so I chose 6.3 branch. Here we are fixing bugs related to invalid HTML contents, so that's why I chose 5.4 branch. The issue related to `<summary>` is that it only allows tags that can be included inside a `<p>`, but not `<p>` itself (verified with https://validator.w3.org/): <img width="502" alt="summary-p" src="https://user-images.githubusercontent.com/73419/216625646-73f7f73d-a315-43da-9d9a-44ce430c70e5.png"> Commits ------- 31ce660 [WebProfilerBundle] Fix some minor HTML issues
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig
@@ -131,8 +131,10 @@
             </colgroup>
 
             <thead>
-                <th>Time</th>
-                <th>Message</th>
+                <tr>
+                    <th>Time</th>
+                    <th>Message</th>
+                </tr>
             </thead>
 
             <tbody>
@@ -185,7 +187,7 @@
     <details class="container-compilation-logs">
         <summary>
             <h4>Container Compilation Logs <span class="text-muted">({{ compilerLogTotal }})</span></h4>
-            <p class="text-muted">Log messages generated during the compilation of the service container.</p>
+            <span class="text-muted">Log messages generated during the compilation of the service container.</span>
         </summary>
 
         {% if collector.compilerLogs is empty %}
diff --git a/src/Symfony/Component/ErrorHandler/Resources/views/error.html.php b/src/Symfony/Component/ErrorHandler/Resources/views/error.html.php
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
     <meta charset="<?= $this->charset; ?>" />
     <meta name="robots" content="noindex,nofollow,noarchive" />
