bug symfony#54419 Fix TypeError on ProgressBar (Fan2Shrek)

xabbuh · xabbuh · commit 04d547d650b6 · 2024-03-28T20:06:21.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- Fix TypeError on ProgressBar | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony#54386 | License | MIT `ProgressBar->getMessage()` returns null if the message is not defined Commits ------- adfe8df Fix TypeError on ProgressBar
diff --git a/src/Symfony/Component/Console/Helper/ProgressBar.php b/src/Symfony/Component/Console/Helper/ProgressBar.php
@@ -183,9 +183,9 @@ public function setMessage(string $message, string $name = 'message'): void
         $this->messages[$name] = $message;
     }
 
-    public function getMessage(string $name = 'message'): string
+    public function getMessage(string $name = 'message'): ?string
     {
-        return $this->messages[$name];
+        return $this->messages[$name] ?? null;
     }
 
     public function getStartTime(): int

Original file line number	Diff line number	Diff line change
`@@ -183,9 +183,9 @@ public function setMessage(string $message, string $name = 'message'): void`
`183`	`183`	`$this->messages[$name] = $message;`
`184`	`184`	`}`
`185`	`185`
`186`		`- public function getMessage(string $name = 'message'): string`
	`186`	`+ public function getMessage(string $name = 'message'): ?string`
`187`	`187`	`{`
`188`		`- return $this->messages[$name];`
	`188`	`+ return $this->messages[$name] ?? null;`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`public function getStartTime(): int`