bug symfony#53383 [Validator] re-allow an empty list of fields (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] re-allow an empty list of fields

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony#53133 (comment)
| License       | MIT

Commits
-------

098c14c re-allow an empty list of fields

Author: nicolas-grekas

src/Symfony/Component/Validator/Constraints/Collection.php

@@ -42,10 +42,7 @@ class Collection extends Composite
      */
     public function __construct($fields = null, array $groups = null, $payload = null, bool $allowExtraFields = null, bool $allowMissingFields = null, string $extraFieldsMessage = null, string $missingFieldsMessage = null)
     {
-        if (\is_array($fields)
-            && (($firstField = reset($fields)) instanceof Constraint
-                || ($firstField[0] ?? null) instanceof Constraint
-            )) {
+        if (\is_array($fields) && ([] === $fields || ($firstField = reset($fields)) instanceof Constraint || ($firstField[0] ?? null) instanceof Constraint)) {
             $fields = ['fields' => $fields];
         }
 

src/Symfony/Component/Validator/Tests/Constraints/CollectionTest.php

@@ -153,4 +153,24 @@ public function testAllKeysAreKnowOptions()
         $this->assertTrue($constraint->allowExtraFields);
         $this->assertSame('foo bar baz', $constraint->extraFieldsMessage);
     }
+
+    public function testEmptyFields()
+    {
+        $constraint = new Collection([], [], null, true, null, 'foo bar baz');
+
+        $this->assertTrue($constraint->allowExtraFields);
+        $this->assertSame('foo bar baz', $constraint->extraFieldsMessage);
+    }
+
+    public function testEmptyFieldsInOptions()
+    {
+        $constraint = new Collection([
+            'fields' => [],
+            'allowExtraFields' => true,
+            'extraFieldsMessage' => 'foo bar baz',
+        ]);
+
+        $this->assertTrue($constraint->allowExtraFields);
+        $this->assertSame('foo bar baz', $constraint->extraFieldsMessage);
+    }
 }