Skip to content

Commit 3336571

Browse files
committed
minor symfony#50555 [DomCrawler] Fix Crawler::filter throw phpdoc (VincentLanglet)
This PR was merged into the 5.4 branch. Discussion ---------- [DomCrawler] Fix Crawler::filter throw phpdoc | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | not really (phpdoc-fix) | New feature? | no | Deprecations? | no | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> The `Crawler::filter` method is calling ``` $converter = $this->createCssSelectorConverter(); ``` which is throwing a `LogicException` since symfony#28536 So the phpdoc should be ``` `@throws` \LogicException if the CssSelector Component is not available ``` and not ``` `@throws` \RuntimeException if the CssSelector Component is not available ``` Commits ------- ae19695 Fix Crawler::filter throw phpdoc
2 parents 6f76b90 + ae19695 commit 3336571

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/DomCrawler/Crawler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -778,7 +778,7 @@ public function filterXPath(string $xpath)
778778
*
779779
* @return static
780780
*
781-
* @throws \RuntimeException if the CssSelector Component is not available
781+
* @throws \LogicException if the CssSelector Component is not available
782782
*/
783783
public function filter(string $selector)
784784
{

0 commit comments

Comments
 (0)