bug symfony#53260 [AssetMapper] Handle assets with non-ascii characters in dev server (fbourigault)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[AssetMapper] Handle assets with non-ascii characters in dev server

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | n/a
| License       | MIT

In `AssetMapperDevServerSubscriber`, `$event->getRequest()->getPathInfo()` is used to get the path of the asset to serve. As `Request::getPathInfo()` returns the raw path, if the requested asset contains non-ascii characters in it's path, a 404 is returned instead of the asset because of the encoded path info.

Using `rawurldecode` enabled handling of encoded paths.

I just pushed the use of the `rawurldecode` for now as don't known how to test this properly.

I tried renaming `dir1/file1.css` to `dir1/file 1.css` or creating a new `and voilà.css` but both approches affect many other tests.

How could I test this properly?

Commits
-------

27e3d2b [AssetMapper] Handle assets with non-ascii characters in dev server

Author: nicolas-grekas

src/Symfony/Component/AssetMapper/AssetMapperDevServerSubscriber.php

@@ -117,7 +117,7 @@ public function onKernelRequest(RequestEvent $event): void
             return;
         }
 
-        $pathInfo = $event->getRequest()->getPathInfo();
+        $pathInfo = rawurldecode($event->getRequest()->getPathInfo());
         if (!str_starts_with($pathInfo, $this->publicPrefix)) {
             return;
         }

src/Symfony/Component/AssetMapper/Tests/AssetMapperDevServerSubscriberFunctionalTest.php

@@ -32,6 +32,20 @@ public function testGettingAssetWorks()
         $this->assertSame('immutable, max-age=604800, public', $response->headers->get('Cache-Control'));
     }
 
+    public function testGettingAssetWithNonAsciiFilenameWorks()
+    {
+        $client = static::createClient();
+
+        $client->request('GET', '/assets/voilà-6344422da690fcc471f23f7a8966cd1c.css');
+        $response = $client->getResponse();
+        $this->assertSame(200, $response->getStatusCode());
+        $this->assertSame(<<<EOF
+        /* voilà.css */
+        body {}
+
+        EOF, $response->getContent());
+    }
+
     public function test404OnUnknownAsset()
     {
         $client = static::createClient();

src/Symfony/Component/AssetMapper/Tests/Command/AssetsMapperCompileCommandTest.php

@@ -63,7 +63,7 @@ public function testAssetsAreCompiled()
 
         $finder = new Finder();
         $finder->in($targetBuildDir)->files();
-        $this->assertCount(10, $finder);
+        $this->assertCount(11, $finder);
         $this->assertFileExists($targetBuildDir.'/manifest.json');
 
         $this->assertSame([
@@ -74,6 +74,7 @@ public function testAssetsAreCompiled()
             'file4.js',
             'subdir/file5.js',
             'subdir/file6.js',
+            'voilà.css',
         ], array_keys(json_decode(file_get_contents($targetBuildDir.'/manifest.json'), true)));
 
         $this->assertFileExists($targetBuildDir.'/importmap.json');

src/Symfony/Component/AssetMapper/Tests/fixtures/AssetMapperTestAppKernel.php

@@ -40,7 +40,7 @@ public function registerContainerConfiguration(LoaderInterface $loader): void
                 'http_client' => true,
                 'assets' => null,
                 'asset_mapper' => [
-                    'paths' => ['dir1', 'dir2'],
+                    'paths' => ['dir1', 'dir2', 'non_ascii'],
                 ],
                 'test' => true,
             ]);

src/Symfony/Component/AssetMapper/Tests/fixtures/non_ascii/voilà.css

@@ -0,0 +1,2 @@
+/* voilà.css */
+body {}