Skip to content

Commit 4cdead1

Browse files
minor symfony#57462 [FrameworkBundle] Lazy kernel.secret parameter resolving (yceruto)
This PR was merged into the 7.2 branch. Discussion ---------- [FrameworkBundle] Lazy `kernel.secret` parameter resolving | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT symfony#56985 and symfony/recipes#1317 following up The goal of this PR is to fix the current compiler-errors about a missing `kernel.secret` parameter when it's not set at all. Thus, improving the first-time experience with minimalistic apps. Commits ------- 0284011 Lazy kernel.secret parameter resolving
2 parents 7169495 + 0284011 commit 4cdead1

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/Symfony/Bundle/FrameworkBundle/Resources/config/services.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
use Symfony\Component\Console\ConsoleEvents;
2424
use Symfony\Component\DependencyInjection\Config\ContainerParametersResourceChecker;
2525
use Symfony\Component\DependencyInjection\EnvVarProcessor;
26+
use Symfony\Component\DependencyInjection\Parameter;
2627
use Symfony\Component\DependencyInjection\ParameterBag\ContainerBag;
2728
use Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface;
2829
use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
@@ -154,7 +155,7 @@ class_exists(WorkflowEvents::class) ? WorkflowEvents::ALIASES : []
154155

155156
->set('uri_signer', UriSigner::class)
156157
->args([
157-
param('kernel.secret'),
158+
new Parameter('kernel.secret')
158159
])
159160
->alias(UriSigner::class, 'uri_signer')
160161

src/Symfony/Bundle/SecurityBundle/Resources/config/security_authenticator_login_link.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace Symfony\Component\DependencyInjection\Loader\Configurator;
1313

1414
use Symfony\Bundle\SecurityBundle\LoginLink\FirewallAwareLoginLinkHandler;
15+
use Symfony\Component\DependencyInjection\Parameter;
1516
use Symfony\Component\Security\Core\Signature\ExpiredSignatureStorage;
1617
use Symfony\Component\Security\Core\Signature\SignatureHasher;
1718
use Symfony\Component\Security\Http\Authenticator\LoginLinkAuthenticator;
@@ -43,7 +44,7 @@
4344
->args([
4445
service('property_accessor'),
4546
abstract_arg('signature properties'),
46-
'%kernel.secret%',
47+
new Parameter('kernel.secret'),
4748
abstract_arg('expired signature storage'),
4849
abstract_arg('max signature uses'),
4950
])

src/Symfony/Bundle/SecurityBundle/Resources/config/security_authenticator_remember_me.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace Symfony\Component\DependencyInjection\Loader\Configurator;
1313

1414
use Symfony\Bundle\SecurityBundle\RememberMe\FirewallAwareRememberMeHandler;
15+
use Symfony\Component\DependencyInjection\Parameter;
1516
use Symfony\Component\Security\Core\Signature\SignatureHasher;
1617
use Symfony\Component\Security\Http\Authenticator\RememberMeAuthenticator;
1718
use Symfony\Component\Security\Http\EventListener\CheckRememberMeConditionsListener;
@@ -30,7 +31,7 @@
3031
->args([
3132
service('property_accessor'),
3233
abstract_arg('signature properties'),
33-
'%kernel.secret%',
34+
new Parameter('kernel.secret'),
3435
null,
3536
null,
3637
])

0 commit comments

Comments
 (0)