minor symfony#54447 Remove unnecessary empty usages (ostrolucky)

This PR was merged into the 7.1 branch.

Discussion
----------

Remove unnecessary empty usages

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  |no
| Deprecations? |  no
| Issues        |
| License       | MIT

I've written a rector for this rectorphp/rector-src#5783 and decided to apply it on Symfony src here.

As for motivation for removing empty where possible, in my and several other prominent devs opinions, using `empty()` is a bad practice for several reasons:
- it's misleading. It doesn't work with collection or stringable objects. Its meaning is more like `isset($foo) && (bool) $foo` rather than `count($foo) === 0` or `strlen($foo) === 0`, contrary to name of this function.
- it decreases safety of the code, because it's doing implicit `isset` call, so once you remove variable assignment, `empty()` call that references it continues silently working
- it increases complexity because of having to negate the call in most cases (there is no `nonempty()` function)
- it's unnecessary in most cases and hence adds extra opcodes and increases length of code for no good reason

There were also several articles written on this topic, I know about these 2:
- https://www.contextualcode.com/Blog/php-micro-optimization.-variable-boolean-cast-vs-!empty
- https://www.beberlei.de/2021/02/19/when_to_use_empty_in_php_i_say_never.html (this one is from `@beberlei`)

However, personally I'm not in a super strict camp. I like that I don't have to explicitly specify `[] === $foo` or `'' === $foo` or `null === $foo` (and so on and on)  and I think Symfony shares the similar opinion.

Commits
-------

ccc813c Remove unnecessary empty usages

Author: fabpot

src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php

@@ -116,7 +116,7 @@ public function validate(mixed $entity, Constraint $constraint): void
 
         // skip validation if there are no criteria (this can happen when the
         // "ignoreNull" option is enabled and fields to be checked are null
-        if (empty($criteria)) {
+        if (!$criteria) {
             return;
         }
 

src/Symfony/Bridge/Monolog/Formatter/ConsoleFormatter.php

@@ -100,14 +100,14 @@ public function format(LogRecord $record): mixed
     {
         $record = $this->replacePlaceHolder($record);
 
-        if (!$this->options['ignore_empty_context_and_extra'] || !empty($record->context)) {
+        if (!$this->options['ignore_empty_context_and_extra'] || $record->context) {
             $context = $record->context;
             $context = ($this->options['multiline'] ? "\n" : ' ').$this->dumpData($context);
         } else {
             $context = '';
         }
 
-        if (!$this->options['ignore_empty_context_and_extra'] || !empty($record->extra)) {
+        if (!$this->options['ignore_empty_context_and_extra'] || $record->extra) {
             $extra = $record->extra;
             $extra = ($this->options['multiline'] ? "\n" : ' ').$this->dumpData($extra);
         } else {

src/Symfony/Bridge/PsrHttpMessage/Factory/PsrHttpFactory.php

@@ -178,7 +178,7 @@ public function createResponse(Response $symfonyResponse): ResponseInterface
 
         $headers = $symfonyResponse->headers->all();
         $cookies = $symfonyResponse->headers->getCookies();
-        if (!empty($cookies)) {
+        if ($cookies) {
             $headers['Set-Cookie'] = [];
 
             foreach ($cookies as $cookie) {

src/Symfony/Bridge/PsrHttpMessage/Tests/Fixtures/Uri.php

@@ -47,13 +47,13 @@ public function getScheme(): string
 
     public function getAuthority(): string
     {
-        if (empty($this->host)) {
+        if (!$this->host) {
             return '';
         }
 
         $authority = $this->host;
 
-        if (!empty($this->userInfo)) {
+        if ($this->userInfo) {
             $authority = $this->userInfo.'@'.$authority;
         }
 

src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php

@@ -275,7 +275,7 @@ public function searchAction(Request $request): Response
             $session->set('_profiler_search_type', $profileType);
         }
 
-        if (!empty($token)) {
+        if ($token) {
             return new RedirectResponse($this->generator->generate('_profiler', ['token' => $token]), 302, ['Content-Type' => 'text/html']);
         }
 

src/Symfony/Component/BrowserKit/AbstractBrowser.php

@@ -531,7 +531,7 @@ public function reload(): Crawler
      */
     public function followRedirect(): Crawler
     {
-        if (empty($this->redirect)) {
+        if (!$this->redirect) {
             throw new LogicException('The request was not redirected.');
         }
 

src/Symfony/Component/BrowserKit/Cookie.php

@@ -71,7 +71,7 @@ public function __construct(
             $this->value = $value ?? '';
             $this->rawValue = rawurlencode($this->value);
         }
-        $this->path = empty($path) ? '/' : $path;
+        $this->path = $path ?: '/';
 
         if (null !== $expires) {
             $timestampAsDateTime = \DateTimeImmutable::createFromFormat('U', $expires);

src/Symfony/Component/BrowserKit/CookieJar.php

@@ -71,7 +71,7 @@ public function expire(string $name, ?string $path = '/', ?string $domain = null
     {
         $path ??= '/';
 
-        if (empty($domain)) {
+        if (!$domain) {
             // an empty domain means any domain
             // this should never happen but it allows for a better BC
             $domains = array_keys($this->cookieJar);

src/Symfony/Component/Cache/Adapter/CouchbaseBucketAdapter.php

@@ -112,7 +112,7 @@ public static function createConnection(#[\SensitiveParameter] array|string $ser
 
             unset($options['username'], $options['password']);
             foreach ($options as $option => $value) {
-                if (!empty($value)) {
+                if ($value) {
                     $bucket->$option = $value;
                 }
             }

src/Symfony/Component/Config/Definition/Builder/ExprBuilder.php

@@ -100,7 +100,7 @@ public function ifNull(): static
      */
     public function ifEmpty(): static
     {
-        $this->ifPart = static fn ($v) => empty($v);
+        $this->ifPart = static fn ($v) => !$v;
         $this->allowedTypes = self::TYPE_ANY;
 
         return $this;