Merge branch '5.4' into 6.3

* 5.4:
  [Config] Prefixing FileExistenceResource::__toString() to avoid conflict with FileResource
  [String] Method toByteString conversion using iconv is unreachable
  [HttpKernel] Fix PHP deprecation

Author: nicolas-grekas

src/Symfony/Component/Config/Resource/FileExistenceResource.php

@@ -38,7 +38,7 @@ public function __construct(string $resource)
 
     public function __toString(): string
     {
-        return $this->resource;
+        return 'existence.'.$this->resource;
     }
 
     public function getResource(): string

src/Symfony/Component/Config/Tests/Resource/FileExistenceResourceTest.php

@@ -36,7 +36,7 @@ protected function tearDown(): void
 
     public function testToString()
     {
-        $this->assertSame($this->file, (string) $this->resource);
+        $this->assertSame('existence.'.$this->file, (string) $this->resource);
     }
 
     public function testGetResource()

src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php

@@ -210,7 +210,7 @@ private function getContainerDeprecationLogs(): array
 
     private function getContainerCompilerLogs(string $compilerLogsFilepath = null): array
     {
-        if (!is_file($compilerLogsFilepath)) {
+        if (!$compilerLogsFilepath || !is_file($compilerLogsFilepath)) {
             return [];
         }
 

src/Symfony/Component/String/AbstractString.php

@@ -512,8 +512,11 @@ public function toByteString(string $toEncoding = null): ByteString
         try {
             try {
                 $b->string = mb_convert_encoding($this->string, $toEncoding, 'UTF-8');
-            } catch (InvalidArgumentException $e) {
+            } catch (InvalidArgumentException|\ValueError $e) {
                 if (!\function_exists('iconv')) {
+                    if ($e instanceof \ValueError) {
+                        throw new InvalidArgumentException($e->getMessage(), $e->getCode(), $e);
+                    }
                     throw $e;
                 }
 

src/Symfony/Component/String/Tests/AbstractAsciiTestCase.php

@@ -1581,4 +1581,22 @@ public static function provideWidth(): array
             [17, "\u{007f}\u{007f}f\u{001b}[0moo\u{0001}bar\u{007f}cccïf\u{008e}cy\u{0005}1", false], // f[0moobarcccïfcy1
         ];
     }
+
+    /**
+     * @dataProvider provideToByteString
+     */
+    public function testToByteString(string $origin, string $encoding)
+    {
+        $instance = static::createFromString($origin)->toByteString($encoding);
+        $this->assertInstanceOf(ByteString::class, $instance);
+    }
+
+    public static function provideToByteString(): array
+    {
+        return [
+            ['žsžsý', 'UTF-8'],
+            ['žsžsý', 'windows-1250'],
+            ['žsžsý', 'Windows-1252'],
+        ];
+    }
 }