Remove useless code

Author: alexandre-daubois

src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php

@@ -307,7 +307,7 @@ private function createFirewalls(array $config, ContainerBuilder $container): vo
 
             $configId = 'security.firewall.map.config.'.$name;
 
-            [$matcher, $listeners, $exceptionListener, $logoutListener, $firewallAuthenticators] = $this->createFirewall($container, $name, $firewall, $authenticationProviders, $providerIds, $configId);
+            [$matcher, $listeners, $exceptionListener, $logoutListener, $firewallAuthenticators] = $this->createFirewall($container, $name, $firewall, $providerIds, $configId);
 
             if (!$firewallAuthenticators) {
                 $authenticators[$name] = null;
@@ -348,7 +348,7 @@ private function createFirewalls(array $config, ContainerBuilder $container): vo
         }
     }
 
-    private function createFirewall(ContainerBuilder $container, string $id, array $firewall, array &$authenticationProviders, array $providerIds, string $configId): array
+    private function createFirewall(ContainerBuilder $container, string $id, array $firewall, array $providerIds, string $configId): array
     {
         $config = $container->setDefinition($configId, new ChildDefinition('security.firewall.config'));
         $config->replaceArgument(0, $id);

src/Symfony/Component/Form/Extension/Core/Type/TimeType.php

@@ -60,7 +60,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
 
         if ('single_text' === $options['widget']) {
             $builder->addEventListener(FormEvents::PRE_SUBMIT, static function (FormEvent $e) use ($options) {
-                /** @var PreSubmitEvent $event */
                 $data = $e->getData();
                 if ($data && preg_match('/^(?P<hours>\d{2}):(?P<minutes>\d{2})(?::(?P<seconds>\d{2})(?:\.\d+)?)?$/', $data, $matches)) {
                     if ($options['with_seconds']) {

src/Symfony/Component/Intl/Data/Generator/TimezoneDataGenerator.php

@@ -121,8 +121,6 @@ protected function generateDataForRoot(BundleEntryReaderInterface $reader, strin
 
     protected function generateDataForMeta(BundleEntryReaderInterface $reader, string $tempDir): ?array
     {
-        $rootBundle = $reader->read($tempDir, 'root');
-
         $this->zoneIds = array_unique($this->zoneIds);
 
         sort($this->zoneIds);

src/Symfony/Component/Lock/Store/PostgreSqlStore.php

@@ -169,7 +169,7 @@ public function exists(Key $key): bool
         $stmt = $this->getConnection()->prepare($sql);
 
         $stmt->bindValue(':key', $this->getHashedKey($key));
-        $result = $stmt->execute();
+        $stmt->execute();
 
         if ($stmt->fetchColumn() > 0) {
             // connection is locked, check for lock in internal store

src/Symfony/Component/Mailer/Bridge/Azure/Transport/AzureApiTransport.php

@@ -65,7 +65,7 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e
 
         $response = $this->client->request('POST', 'https://'.$endpoint, [
             'body' => json_encode($payload),
-            'headers' => $this->getSignedHeaders($payload, $email),
+            'headers' => $this->getSignedHeaders($payload),
         ]);
 
         try {
@@ -189,7 +189,7 @@ private function generateAuthenticationSignature(string $content): string
     /**
      * Get authenticated headers for signed request,.
      */
-    private function getSignedHeaders(array $payload, Email $message): array
+    private function getSignedHeaders(array $payload): array
     {
         // HTTP Method verb (uppercase)
         $verb = 'POST';

src/Symfony/Component/Mailer/Bridge/Mailgun/Tests/Transport/MailgunApiTransportTest.php

@@ -103,9 +103,6 @@ public function testCustomHeader()
      */
     public function testPrefixHeaderWithH()
     {
-        $json = json_encode(['foo' => 'bar']);
-        $deliveryTime = (new \DateTimeImmutable('2020-03-20 13:01:00'))->format(\DateTimeInterface::RFC2822);
-
         $email = new Email();
         $email->getHeaders()->addTextHeader('h:bar', 'bar-value');
 

src/Symfony/Component/Messenger/Bridge/AmazonSqs/Tests/Transport/AmazonSqsReceiverTest.php

@@ -67,10 +67,8 @@ private function createSqsEnvelope()
 
     private function createSerializer(): Serializer
     {
-        $serializer = new Serializer(
+        return new Serializer(
             new SerializerComponent\Serializer([new ObjectNormalizer()], ['json' => new JsonEncoder()])
         );
-
-        return $serializer;
     }
 }

src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php

@@ -157,7 +157,7 @@ public static function fromDsn(#[\SensitiveParameter] string $dsn, array $option
         }
 
         $parsedPath = explode('/', ltrim($params['path'] ?? '/', '/'));
-        if (\count($parsedPath) > 0 && ($queueName = end($parsedPath))) {
+        if ($queueName = end($parsedPath)) {
             $configuration['queue_name'] = $queueName;
         }
         $configuration['account'] = 2 === \count($parsedPath) ? $parsedPath[0] : $options['account'] ?? self::DEFAULT_OPTIONS['account'];

src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php

@@ -318,7 +318,7 @@ public function countMessagesInQueues(): int
     private function publishWithDelay(string $body, array $headers, int $delay, ?AmqpStamp $amqpStamp = null): void
     {
         $routingKey = $this->getRoutingKeyForMessage($amqpStamp);
-        $isRetryAttempt = $amqpStamp ? $amqpStamp->isRetryAttempt() : false;
+        $isRetryAttempt = $amqpStamp && $amqpStamp->isRetryAttempt();
 
         $this->setupDelay($delay, $routingKey, $isRetryAttempt);
 

src/Symfony/Component/Messenger/Bridge/Beanstalkd/Tests/Transport/BeanstalkdReceiverTest.php

@@ -91,10 +91,8 @@ private function createBeanstalkdEnvelope(): array
 
     private function createSerializer(): Serializer
     {
-        $serializer = new Serializer(
+        return new Serializer(
             new SerializerComponent\Serializer([new ObjectNormalizer()], ['json' => new JsonEncoder()])
         );
-
-        return $serializer;
     }
 }