minor symfony#57792 Replace TestCase::assertTrue(true) with TestCase::expectNotToPerformAssertions() (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

Replace `TestCase::assertTrue(true)` with `TestCase::expectNotToPerformAssertions()`

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Commits
-------

ee8509e Replace `TestCase::assertTrue(true)` with `TestCase::expectNotToPerformAssertions()`

Author: xabbuh

src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php

@@ -53,6 +53,8 @@ public function testUnsupportedShellOption()
 
     public function testAdditionalShellSupport()
     {
+        $this->expectNotToPerformAssertions();
+
         $this->command = new CompleteCommand(['supported' => BashCompletionOutput::class]);
         $this->command->setApplication($this->application);
         $this->tester = new CommandTester($this->command);
@@ -61,8 +63,6 @@ public function testAdditionalShellSupport()
 
         // verify that the default set of shells is still supported
         $this->execute(['--shell' => 'bash', '--current' => '1', '--input' => ['bin/console']]);
-
-        $this->assertTrue(true);
     }
 
     /**

src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php

@@ -27,11 +27,10 @@ protected function setUp(): void
      */
     public function testRewindOnFtp()
     {
-        $i = new RecursiveDirectoryIterator('ftp://speedtest:[email protected]/', \RecursiveDirectoryIterator::SKIP_DOTS);
+        $this->expectNotToPerformAssertions();
 
+        $i = new RecursiveDirectoryIterator('ftp://speedtest:[email protected]/', \RecursiveDirectoryIterator::SKIP_DOTS);
         $i->rewind();
-
-        $this->assertTrue(true);
     }
 
     /**

src/Symfony/Component/Mailer/Tests/MailerTest.php

@@ -86,6 +86,8 @@ public function dispatch($message, array $stamps = []): Envelope
 
     public function testRejectMessage()
     {
+        $this->expectNotToPerformAssertions();
+
         $dispatcher = new EventDispatcher();
         $dispatcher->addListener(MessageEvent::class, fn (MessageEvent $event) => $event->reject(), 255);
         $dispatcher->addListener(MessageEvent::class, fn () => throw new \RuntimeException('Should never be called.'));
@@ -111,6 +113,5 @@ public function __toString(): string
         $message = new RawMessage('');
         $envelope = new MailerEnvelope(new Address('[email protected]'), [new Address('[email protected]')]);
         $mailer->send($message, $envelope);
-        $this->assertTrue(true);
     }
 }

src/Symfony/Component/Validator/Tests/Constraints/NotCompromisedPasswordValidatorTest.php

@@ -213,8 +213,9 @@ public function testApiError()
      */
     public function testApiErrorSkipped(NotCompromisedPassword $constraint)
     {
+        $this->expectNotToPerformAssertions();
+
         $this->validator->validate(self::PASSWORD_TRIGGERING_AN_ERROR, $constraint);
-        $this->assertTrue(true); // No exception have been thrown
     }
 
     public static function provideErrorSkippingConstraints(): iterable