minor symfony#58094 Use Stringable whenever possible (fabpot)

This PR was merged into the 7.2 branch.

Discussion
----------

Use Stringable whenever possible

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Issues        | n/a
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

06b4996 Use Stringable whenever possible

Author: fabpot

src/Symfony/Component/BrowserKit/HttpBrowser.php

@@ -99,7 +99,7 @@ private function getBodyAndExtraHeaders(Request $request, array $headers): array
                 if ($vars = get_object_vars($v)) {
                     array_walk_recursive($vars, $caster);
                     $v = $vars;
-                } elseif (method_exists($v, '__toString')) {
+                } elseif ($v instanceof \Stringable) {
                     $v = (string) $v;
                 }
             }

src/Symfony/Component/DependencyInjection/Compiler/CheckTypeDeclarationsPass.php

@@ -274,7 +274,7 @@ private function checkType(Definition $checkedDefinition, mixed $value, \Reflect
             return;
         }
 
-        if ('string' === $type && method_exists($class, '__toString')) {
+        if ('string' === $type && $class instanceof \Stringable) {
             return;
         }
 

src/Symfony/Component/ErrorHandler/BufferingLogger.php

@@ -50,7 +50,7 @@ public function __destruct()
         foreach ($this->logs as [$level, $message, $context]) {
             if (str_contains($message, '{')) {
                 foreach ($context as $key => $val) {
-                    if (null === $val || \is_scalar($val) || (\is_object($val) && \is_callable([$val, '__toString']))) {
+                    if (null === $val || \is_scalar($val) || $val instanceof \Stringable) {
                         $message = str_replace("{{$key}}", $val, $message);
                     } elseif ($val instanceof \DateTimeInterface) {
                         $message = str_replace("{{$key}}", $val->format(\DateTimeInterface::RFC3339), $message);

src/Symfony/Component/HttpFoundation/JsonResponse.php

@@ -40,7 +40,7 @@ public function __construct(mixed $data = null, int $status = 200, array $header
     {
         parent::__construct('', $status, $headers);
 
-        if ($json && !\is_string($data) && !is_numeric($data) && !\is_callable([$data, '__toString'])) {
+        if ($json && !\is_string($data) && !is_numeric($data) && !$data instanceof \Stringable) {
             throw new \TypeError(\sprintf('"%s": If $json is set to true, argument $data must be a string or object implementing __toString(), "%s" given.', __METHOD__, get_debug_type($data)));
         }
 

src/Symfony/Component/Routing/Generator/UrlGenerator.php

@@ -266,7 +266,7 @@ protected function doGenerate(array $variables, array $defaults, array $requirem
                 if ($vars = get_object_vars($v)) {
                     array_walk_recursive($vars, $caster);
                     $v = $vars;
-                } elseif (method_exists($v, '__toString')) {
+                } elseif ($v instanceof \Stringable) {
                     $v = (string) $v;
                 }
             }

src/Symfony/Component/Security/Core/Authorization/TraceableAccessDecisionManager.php

@@ -85,7 +85,7 @@ public function getStrategy(): string
         if (null === $this->strategy) {
             return '-';
         }
-        if (method_exists($this->strategy, '__toString')) {
+        if ($this->strategy instanceof \Stringable) {
             return (string) $this->strategy;
         }
 

src/Symfony/Component/Security/Http/Authenticator/FormLoginAuthenticator.php

@@ -133,15 +133,15 @@ private function getCredentials(Request $request): array
 
         $request->getSession()->set(SecurityRequestAttributes::LAST_USERNAME, $credentials['username']);
 
-        if (!\is_string($credentials['password']) && (!\is_object($credentials['password']) || !method_exists($credentials['password'], '__toString'))) {
+        if (!\is_string($credentials['password']) && !$credentials['password'] instanceof \Stringable) {
             throw new BadRequestHttpException(\sprintf('The key "%s" must be a string, "%s" given.', $this->options['password_parameter'], \gettype($credentials['password'])));
         }
 
         if ('' === (string) $credentials['password']) {
             throw new BadCredentialsException(\sprintf('The key "%s" must be a non-empty string.', $this->options['password_parameter']));
         }
 
-        if (!\is_string($credentials['csrf_token'] ?? '') && (!\is_object($credentials['csrf_token']) || !method_exists($credentials['csrf_token'], '__toString'))) {
+        if (!\is_string($credentials['csrf_token'] ?? '') && !$credentials['csrf_token'] instanceof \Stringable) {
             throw new BadRequestHttpException(\sprintf('The key "%s" must be a string, "%s" given.', $this->options['csrf_parameter'], \gettype($credentials['csrf_token'])));
         }