minor symfony#57729 Use createMock (OskarStark)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Use `createMock`

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

266f7b6 Use `createMock`

Author: xabbuh

src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php

@@ -30,7 +30,7 @@ class EntityValueResolverTest extends TestCase
 {
     public function testResolveWithoutClass()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -42,7 +42,7 @@ public function testResolveWithoutClass()
 
     public function testResolveWithoutAttribute()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry, null, new MapEntity(disabled: true));
 
@@ -68,7 +68,7 @@ public function testResolveWithoutManager()
      */
     public function testResolveWithNoIdAndDataOptional()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -80,7 +80,7 @@ public function testResolveWithNoIdAndDataOptional()
 
     public function testResolveWithStripNulls()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -102,7 +102,7 @@ public function testResolveWithStripNulls()
      */
     public function testResolveWithId(string|int $id)
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -111,7 +111,7 @@ public function testResolveWithId(string|int $id)
 
         $argument = $this->createArgument('stdClass', new MapEntity(id: 'id'));
 
-        $repository = $this->getMockBuilder(ObjectRepository::class)->getMock();
+        $repository = $this->createMock(ObjectRepository::class);
         $repository->expects($this->once())
             ->method('find')
             ->with($id)
@@ -127,7 +127,7 @@ public function testResolveWithId(string|int $id)
 
     public function testResolveWithNullId()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -141,7 +141,7 @@ public function testResolveWithNullId()
 
     public function testResolveWithConversionFailedException()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -150,7 +150,7 @@ public function testResolveWithConversionFailedException()
 
         $argument = $this->createArgument('stdClass', new MapEntity(id: 'id', message: 'Test'));
 
-        $repository = $this->getMockBuilder(ObjectRepository::class)->getMock();
+        $repository = $this->createMock(ObjectRepository::class);
         $repository->expects($this->once())
             ->method('find')
             ->with('test')
@@ -169,7 +169,7 @@ public function testResolveWithConversionFailedException()
 
     public function testUsedProperIdentifier()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -195,7 +195,7 @@ public static function idsProvider(): iterable
      */
     public function testResolveGuessOptional()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -204,7 +204,7 @@ public function testResolveGuessOptional()
 
         $argument = $this->createArgument('stdClass', new MapEntity(), 'arg', true);
 
-        $metadata = $this->getMockBuilder(ClassMetadata::class)->getMock();
+        $metadata = $this->createMock(ClassMetadata::class);
         $manager->expects($this->once())
             ->method('getClassMetadata')
             ->with('stdClass')
@@ -217,7 +217,7 @@ public function testResolveGuessOptional()
 
     public function testResolveWithMappingAndExclude()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -233,7 +233,7 @@ public function testResolveWithMappingAndExclude()
         $manager->expects($this->never())
             ->method('getClassMetadata');
 
-        $repository = $this->getMockBuilder(ObjectRepository::class)->getMock();
+        $repository = $this->createMock(ObjectRepository::class);
         $repository->expects($this->once())
             ->method('findOneBy')
             ->with(['Foo' => 1])
@@ -249,7 +249,7 @@ public function testResolveWithMappingAndExclude()
 
     public function testResolveWithRouteMapping()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -267,7 +267,7 @@ public function testResolveWithRouteMapping()
         $conference = new \stdClass();
         $article = new \stdClass();
 
-        $repository = $this->getMockBuilder(ObjectRepository::class)->getMock();
+        $repository = $this->createMock(ObjectRepository::class);
         $repository->expects($this->any())
             ->method('findOneBy')
             ->willReturnCallback(static fn ($v) => match ($v) {
@@ -285,7 +285,7 @@ public function testResolveWithRouteMapping()
 
     public function testExceptionWithExpressionIfNoLanguageAvailable()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -303,9 +303,9 @@ public function testExceptionWithExpressionIfNoLanguageAvailable()
 
     public function testExpressionFailureReturns404()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
-        $language = $this->getMockBuilder(ExpressionLanguage::class)->getMock();
+        $language = $this->createMock(ExpressionLanguage::class);
         $resolver = new EntityValueResolver($registry, $language);
 
         $this->expectException(NotFoundHttpException::class);
@@ -317,7 +317,7 @@ public function testExpressionFailureReturns404()
             'arg1'
         );
 
-        $repository = $this->getMockBuilder(ObjectRepository::class)->getMock();
+        $repository = $this->createMock(ObjectRepository::class);
         // find should not be attempted on this repository as a fallback
         $repository->expects($this->never())
             ->method('find');
@@ -336,9 +336,9 @@ public function testExpressionFailureReturns404()
 
     public function testExpressionMapsToArgument()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
-        $language = $this->getMockBuilder(ExpressionLanguage::class)->getMock();
+        $language = $this->createMock(ExpressionLanguage::class);
         $resolver = new EntityValueResolver($registry, $language);
 
         $request = new Request();
@@ -349,7 +349,7 @@ public function testExpressionMapsToArgument()
             'arg1'
         );
 
-        $repository = $this->getMockBuilder(ObjectRepository::class)->getMock();
+        $repository = $this->createMock(ObjectRepository::class);
         // find should not be attempted on this repository as a fallback
         $repository->expects($this->never())
             ->method('find');
@@ -415,9 +415,9 @@ class: \stdClass::class,
 
     public function testExpressionSyntaxErrorThrowsException()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
-        $language = $this->getMockBuilder(ExpressionLanguage::class)->getMock();
+        $language = $this->createMock(ExpressionLanguage::class);
         $resolver = new EntityValueResolver($registry, $language);
 
         $request = new Request();
@@ -427,7 +427,7 @@ public function testExpressionSyntaxErrorThrowsException()
             'arg1'
         );
 
-        $repository = $this->getMockBuilder(ObjectRepository::class)->getMock();
+        $repository = $this->createMock(ObjectRepository::class);
         // find should not be attempted on this repository as a fallback
         $repository->expects($this->never())
             ->method('find');
@@ -448,7 +448,7 @@ public function testExpressionSyntaxErrorThrowsException()
 
     public function testAlreadyResolved()
     {
-        $manager = $this->getMockBuilder(ObjectManager::class)->getMock();
+        $manager = $this->createMock(ObjectManager::class);
         $registry = $this->createRegistry($manager);
         $resolver = new EntityValueResolver($registry);
 
@@ -467,7 +467,7 @@ private function createArgument(?string $class = null, ?MapEntity $entity = null
 
     private function createRegistry(?ObjectManager $manager = null): ManagerRegistry&MockObject
     {
-        $registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
+        $registry = $this->createMock(ManagerRegistry::class);
 
         $registry->expects($this->any())
             ->method('getManagerForClass')

src/Symfony/Bundle/FrameworkBundle/Tests/Controller/AbstractControllerTest.php

@@ -431,7 +431,7 @@ public function testRenderViewWithForm()
     {
         $formView = new FormView();
 
-        $form = $this->getMockBuilder(FormInterface::class)->getMock();
+        $form = $this->createMock(FormInterface::class);
         $form->expects($this->once())->method('createView')->willReturn($formView);
 
         $twig = $this->getMockBuilder(Environment::class)->disableOriginalConstructor()->getMock();
@@ -452,7 +452,7 @@ public function testRenderWithFormSubmittedAndInvalid()
     {
         $formView = new FormView();
 
-        $form = $this->getMockBuilder(FormInterface::class)->getMock();
+        $form = $this->createMock(FormInterface::class);
         $form->expects($this->once())->method('createView')->willReturn($formView);
         $form->expects($this->once())->method('isSubmitted')->willReturn(true);
         $form->expects($this->once())->method('isValid')->willReturn(false);

src/Symfony/Component/HttpKernel/Tests/EventListener/CacheAttributeListenerTest.php

@@ -330,7 +330,7 @@ private function createEventMock(Request $request, Response $response): Response
 
     private function getKernel(): MockObject&HttpKernelInterface
     {
-        return $this->getMockBuilder(HttpKernelInterface::class)->getMock();
+        return $this->createMock(HttpKernelInterface::class);
     }
 }
 

src/Symfony/Component/Messenger/Tests/WorkerTest.php

@@ -384,7 +384,7 @@ public function testWorkerLimitQueues()
             ->method('get')
         ;
 
-        $bus = $this->getMockBuilder(MessageBusInterface::class)->getMock();
+        $bus = $this->createMock(MessageBusInterface::class);
 
         $dispatcher = new EventDispatcher();
         $dispatcher->addSubscriber(new StopWorkerOnMessageLimitListener(1));
@@ -398,7 +398,7 @@ public function testWorkerLimitQueuesUnsupported()
         $receiver1 = $this->createMock(QueueReceiverInterface::class);
         $receiver2 = $this->createMock(ReceiverInterface::class);
 
-        $bus = $this->getMockBuilder(MessageBusInterface::class)->getMock();
+        $bus = $this->createMock(MessageBusInterface::class);
 
         $worker = new Worker(['transport1' => $receiver1, 'transport2' => $receiver2], $bus, clock: new MockClock());
         $this->expectException(RuntimeException::class);