Bump ext-redis in CI on PHP >= 8.4

Author: nicolas-grekas

.github/workflows/unit-tests.yml

@@ -34,6 +34,7 @@ jobs:
             mode: low-deps
           - php: '8.3'
           - php: '8.4'
+            extensions: amqp,apcu,igbinary,intl,mbstring,memcached,redis
             #mode: experimental
       fail-fast: false
 
@@ -51,7 +52,7 @@ jobs:
           coverage: "none"
           ini-values: date.timezone=UTC,memory_limit=-1,default_socket_timeout=10,session.gc_probability=0,apc.enable_cli=1,zend.assertions=1
           php-version: "${{ matrix.php }}"
-          extensions: "${{ env.extensions }}"
+          extensions: "${{ matrix.extensions || env.extensions }}"
           tools: flex
 
       - name: Configure environment

src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php

@@ -154,7 +154,7 @@ public function testKeepGettingPendingMessages()
         $redis = $this->createMock(\Redis::class);
 
         $redis->expects($this->exactly(3))->method('xreadgroup')
-            ->with('symfony', 'consumer', ['queue' => 0], 1, null)
+            ->with('symfony', 'consumer', ['queue' => 0], 1, 1)
             ->willReturn(['queue' => [['message' => json_encode(['body' => 'Test', 'headers' => []])]]]);
 
         $connection = Connection::fromDsn('redis://localhost/queue', ['delete_after_ack' => true], $redis);
@@ -250,7 +250,7 @@ public function testGetPendingMessageFirst()
         $redis = $this->createMock(\Redis::class);
 
         $redis->expects($this->exactly(1))->method('xreadgroup')
-            ->with('symfony', 'consumer', ['queue' => '0'], 1, null)
+            ->with('symfony', 'consumer', ['queue' => '0'], 1, 1)
             ->willReturn(['queue' => [['message' => '{"body":"1","headers":[]}']]]);
 
         $connection = Connection::fromDsn('redis://localhost/queue', ['delete_after_ack' => true], $redis);
@@ -275,11 +275,11 @@ public function testClaimAbandonedMessageWithRaceCondition()
             ->willReturnCallback(function (...$args) {
                 static $series = [
                     // first call for pending messages
-                    [['symfony', 'consumer', ['queue' => '0'], 1, null], []],
+                    [['symfony', 'consumer', ['queue' => '0'], 1, 1], []],
                     // second call because of claimed message (redisid-123)
-                    [['symfony', 'consumer', ['queue' => '0'], 1, null], []],
+                    [['symfony', 'consumer', ['queue' => '0'], 1, 1], []],
                     // third call because of no result (other consumer claimed message redisid-123)
-                    [['symfony', 'consumer', ['queue' => '>'], 1, null], []],
+                    [['symfony', 'consumer', ['queue' => '>'], 1, 1], []],
                 ];
 
                 [$expectedArgs, $return] = array_shift($series);
@@ -311,9 +311,9 @@ public function testClaimAbandonedMessage()
             ->willReturnCallback(function (...$args) {
                 static $series = [
                     // first call for pending messages
-                    [['symfony', 'consumer', ['queue' => '0'], 1, null], []],
+                    [['symfony', 'consumer', ['queue' => '0'], 1, 1], []],
                     // second call because of claimed message (redisid-123)
-                    [['symfony', 'consumer', ['queue' => '0'], 1, null], ['queue' => [['message' => '{"body":"1","headers":[]}']]]],
+                    [['symfony', 'consumer', ['queue' => '0'], 1, 1], ['queue' => [['message' => '{"body":"1","headers":[]}']]]],
                 ];
 
                 [$expectedArgs, $return] = array_shift($series);

src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php

@@ -389,6 +389,7 @@ public function get(): ?array
                 $this->group,
                 $this->consumer,
                 [$this->stream => $messageId],
+                1,
                 1
             );
         } catch (\RedisException $e) {