Skip to content

Commit c6b16a9

Browse files
feature symfony#58351 [Mailer] deprecate the TransportFactoryTestCase (xabbuh)
This PR was merged into the 7.2 branch. Discussion ---------- [Mailer] deprecate the TransportFactoryTestCase | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | | License | MIT Commits ------- e878066 deprecate the TransportFactoryTestCase
2 parents 3de6a5d + e878066 commit c6b16a9

File tree

41 files changed

+263
-132
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+263
-132
lines changed

UPGRADE-7.2.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,14 @@ Ldap
4747

4848
* Add methods for `saslBind()` and `whoami()` to `ConnectionInterface` and `LdapInterface`
4949

50+
Mailer
51+
------
52+
53+
* Deprecate `TransportFactoryTestCase`, extend `AbstractTransportFactoryTestCase` instead
54+
55+
The `testIncompleteDsnException()` test is no longer provided by default. If you make use of it by implementing the `incompleteDsnProvider()` data providers,
56+
you now need to use the `IncompleteDsnTestTrait`.
57+
5058
Messenger
5159
---------
5260

src/Symfony/Component/Mailer/Bridge/Amazon/Tests/Transport/SesTransportFactoryTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,15 @@
1919
use Symfony\Component\Mailer\Bridge\Amazon\Transport\SesHttpAsyncAwsTransport;
2020
use Symfony\Component\Mailer\Bridge\Amazon\Transport\SesSmtpTransport;
2121
use Symfony\Component\Mailer\Bridge\Amazon\Transport\SesTransportFactory;
22-
use Symfony\Component\Mailer\Test\TransportFactoryTestCase;
22+
use Symfony\Component\Mailer\Test\AbstractTransportFactoryTestCase;
23+
use Symfony\Component\Mailer\Test\IncompleteDsnTestTrait;
2324
use Symfony\Component\Mailer\Transport\Dsn;
2425
use Symfony\Component\Mailer\Transport\TransportFactoryInterface;
2526

26-
class SesTransportFactoryTest extends TransportFactoryTestCase
27+
class SesTransportFactoryTest extends AbstractTransportFactoryTestCase
2728
{
29+
use IncompleteDsnTestTrait;
30+
2831
public function getFactory(): TransportFactoryInterface
2932
{
3033
return new SesTransportFactory(null, new MockHttpClient(), new NullLogger());

src/Symfony/Component/Mailer/Bridge/Amazon/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"async-aws/ses": "^1.3",
21-
"symfony/mailer": "^6.4|^7.0"
21+
"symfony/mailer": "^7.2"
2222
},
2323
"require-dev": {
2424
"symfony/http-client": "^6.4|^7.0"

src/Symfony/Component/Mailer/Bridge/Azure/Tests/Transport/AzureTransportFactoryTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,15 @@
1515
use Symfony\Component\HttpClient\MockHttpClient;
1616
use Symfony\Component\Mailer\Bridge\Azure\Transport\AzureApiTransport;
1717
use Symfony\Component\Mailer\Bridge\Azure\Transport\AzureTransportFactory;
18-
use Symfony\Component\Mailer\Test\TransportFactoryTestCase;
18+
use Symfony\Component\Mailer\Test\AbstractTransportFactoryTestCase;
19+
use Symfony\Component\Mailer\Test\IncompleteDsnTestTrait;
1920
use Symfony\Component\Mailer\Transport\Dsn;
2021
use Symfony\Component\Mailer\Transport\TransportFactoryInterface;
2122

22-
class AzureTransportFactoryTest extends TransportFactoryTestCase
23+
class AzureTransportFactoryTest extends AbstractTransportFactoryTestCase
2324
{
25+
use IncompleteDsnTestTrait;
26+
2427
public function getFactory(): TransportFactoryInterface
2528
{
2629
return new AzureTransportFactory(null, new MockHttpClient(), new NullLogger());

src/Symfony/Component/Mailer/Bridge/Azure/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
],
1818
"require": {
1919
"php": ">=8.2",
20-
"symfony/mailer": "^6.4|^7.0"
20+
"symfony/mailer": "^7.2"
2121
},
2222
"require-dev": {
2323
"symfony/http-client": "^6.4|^7.0"

src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Transport/BrevoTransportFactoryTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,15 @@
1616
use Symfony\Component\Mailer\Bridge\Brevo\Transport\BrevoApiTransport;
1717
use Symfony\Component\Mailer\Bridge\Brevo\Transport\BrevoSmtpTransport;
1818
use Symfony\Component\Mailer\Bridge\Brevo\Transport\BrevoTransportFactory;
19-
use Symfony\Component\Mailer\Test\TransportFactoryTestCase;
19+
use Symfony\Component\Mailer\Test\AbstractTransportFactoryTestCase;
20+
use Symfony\Component\Mailer\Test\IncompleteDsnTestTrait;
2021
use Symfony\Component\Mailer\Transport\Dsn;
2122
use Symfony\Component\Mailer\Transport\TransportFactoryInterface;
2223

23-
class BrevoTransportFactoryTest extends TransportFactoryTestCase
24+
class BrevoTransportFactoryTest extends AbstractTransportFactoryTestCase
2425
{
26+
use IncompleteDsnTestTrait;
27+
2528
public function getFactory(): TransportFactoryInterface
2629
{
2730
return new BrevoTransportFactory(null, new MockHttpClient(), new NullLogger());

src/Symfony/Component/Mailer/Bridge/Brevo/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
],
1818
"require": {
1919
"php": ">=8.1",
20-
"symfony/mailer": "^5.4.21|^6.2.7|^7.0"
20+
"symfony/mailer": "^7.2"
2121
},
2222
"require-dev": {
2323
"symfony/http-client": "^6.3|^7.0",

src/Symfony/Component/Mailer/Bridge/Google/Tests/Transport/GmailTransportFactoryTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,15 @@
1515
use Symfony\Component\HttpClient\MockHttpClient;
1616
use Symfony\Component\Mailer\Bridge\Google\Transport\GmailSmtpTransport;
1717
use Symfony\Component\Mailer\Bridge\Google\Transport\GmailTransportFactory;
18-
use Symfony\Component\Mailer\Test\TransportFactoryTestCase;
18+
use Symfony\Component\Mailer\Test\AbstractTransportFactoryTestCase;
19+
use Symfony\Component\Mailer\Test\IncompleteDsnTestTrait;
1920
use Symfony\Component\Mailer\Transport\Dsn;
2021
use Symfony\Component\Mailer\Transport\TransportFactoryInterface;
2122

22-
class GmailTransportFactoryTest extends TransportFactoryTestCase
23+
class GmailTransportFactoryTest extends AbstractTransportFactoryTestCase
2324
{
25+
use IncompleteDsnTestTrait;
26+
2427
public function getFactory(): TransportFactoryInterface
2528
{
2629
return new GmailTransportFactory(null, new MockHttpClient(), new NullLogger());

src/Symfony/Component/Mailer/Bridge/Google/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
],
1818
"require": {
1919
"php": ">=8.2",
20-
"symfony/mailer": "^6.4|^7.0"
20+
"symfony/mailer": "^7.2"
2121
},
2222
"require-dev": {
2323
"symfony/http-client": "^6.4|^7.0"

src/Symfony/Component/Mailer/Bridge/Infobip/Tests/Transport/InfobipApiTransportFactoryTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,15 @@
1616
use Symfony\Component\Mailer\Bridge\Infobip\Transport\InfobipApiTransport;
1717
use Symfony\Component\Mailer\Bridge\Infobip\Transport\InfobipSmtpTransport;
1818
use Symfony\Component\Mailer\Bridge\Infobip\Transport\InfobipTransportFactory;
19-
use Symfony\Component\Mailer\Test\TransportFactoryTestCase;
19+
use Symfony\Component\Mailer\Test\AbstractTransportFactoryTestCase;
20+
use Symfony\Component\Mailer\Test\IncompleteDsnTestTrait;
2021
use Symfony\Component\Mailer\Transport\Dsn;
2122
use Symfony\Component\Mailer\Transport\TransportFactoryInterface;
2223

23-
class InfobipApiTransportFactoryTest extends TransportFactoryTestCase
24+
class InfobipApiTransportFactoryTest extends AbstractTransportFactoryTestCase
2425
{
26+
use IncompleteDsnTestTrait;
27+
2528
public function getFactory(): TransportFactoryInterface
2629
{
2730
return new InfobipTransportFactory(null, new MockHttpClient(), new NullLogger());

0 commit comments

Comments
 (0)