deprecate the TransportFactoryTestCase

Author: xabbuh

UPGRADE-7.2.md

@@ -52,6 +52,14 @@ Messenger
 
  * Add `getRetryDelay()` method to `RecoverableExceptionInterface`
 
+Notifier
+--------
+
+ * Deprecate `TransportFactoryTestCase`, extend `AbstractTransportFactoryTestCase` instead
+
+   The `testIncompleteDsnException()` and `testMissingRequiredOptionException()` tests are no longer provided by default. If you make use of them (i.e. by implementing the
+   `incompleteDsnProvider()` or `missingRequiredOptionProvider()` data providers), you now need to use the `IncompleteDsnTestTrait` or `MissingRequiredOptionTestTrait` respectively.
+
 Security
 --------
 

src/Symfony/Component/Notifier/Bridge/AllMySms/Tests/AllMySmsTransportFactoryTest.php

@@ -12,10 +12,13 @@
 namespace Symfony\Component\Notifier\Bridge\AllMySms\Tests;
 
 use Symfony\Component\Notifier\Bridge\AllMySms\AllMySmsTransportFactory;
-use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
 
-final class AllMySmsTransportFactoryTest extends TransportFactoryTestCase
+final class AllMySmsTransportFactoryTest extends AbstractTransportFactoryTestCase
 {
+    use IncompleteDsnTestTrait;
+
     public function createFactory(): AllMySmsTransportFactory
     {
         return new AllMySmsTransportFactory();
@@ -44,4 +47,10 @@ public static function unsupportedSchemeProvider(): iterable
     {
         yield ['somethingElse://login:apiKey@default'];
     }
+
+    public static function incompleteDsnProvider(): iterable
+    {
+        yield ['allmysms://login@default'];
+        yield ['allmysms://:apiKey@default'];
+    }
 }

src/Symfony/Component/Notifier/Bridge/AllMySms/composer.json

@@ -18,7 +18,7 @@
     "require": {
         "php": ">=8.2",
         "symfony/http-client": "^6.4|^7.0",
-        "symfony/notifier": "^6.4|^7.0"
+        "symfony/notifier": "^7.2"
     },
     "autoload": {
         "psr-4": { "Symfony\\Component\\Notifier\\Bridge\\AllMySms\\": "" },

src/Symfony/Component/Notifier/Bridge/AmazonSns/Tests/AmazonSnsTransportFactoryTest.php

@@ -12,9 +12,9 @@
 namespace Symfony\Component\Notifier\Bridge\AmazonSns\Tests;
 
 use Symfony\Component\Notifier\Bridge\AmazonSns\AmazonSnsTransportFactory;
-use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
 
-class AmazonSnsTransportFactoryTest extends TransportFactoryTestCase
+class AmazonSnsTransportFactoryTest extends AbstractTransportFactoryTestCase
 {
     public function createFactory(): AmazonSnsTransportFactory
     {

src/Symfony/Component/Notifier/Bridge/AmazonSns/composer.json

@@ -18,7 +18,7 @@
     "require": {
         "php": ">=8.2",
         "symfony/http-client": "^6.4|^7.0",
-        "symfony/notifier": "^6.4|^7.0",
+        "symfony/notifier": "^7.2",
         "async-aws/sns": "^1.0"
     },
     "autoload": {

src/Symfony/Component/Notifier/Bridge/Bandwidth/Tests/BandwidthTransportFactoryTest.php

@@ -12,10 +12,15 @@
 namespace Symfony\Component\Notifier\Bridge\Bandwidth\Tests;
 
 use Symfony\Component\Notifier\Bridge\Bandwidth\BandwidthTransportFactory;
-use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
+use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
 
-final class BandwidthTransportFactoryTest extends TransportFactoryTestCase
+final class BandwidthTransportFactoryTest extends AbstractTransportFactoryTestCase
 {
+    use IncompleteDsnTestTrait;
+    use MissingRequiredOptionTestTrait;
+
     public function createFactory(): BandwidthTransportFactory
     {
         return new BandwidthTransportFactory();

src/Symfony/Component/Notifier/Bridge/Bandwidth/composer.json

@@ -21,7 +21,7 @@
     "require": {
         "php": ">=8.2",
         "symfony/http-client": "^6.4|^7.0",
-        "symfony/notifier": "^6.4|^7.0"
+        "symfony/notifier": "^7.2"
     },
     "require-dev": {
         "symfony/event-dispatcher": "^6.4|^7.0"

src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportFactoryTest.php

@@ -12,10 +12,13 @@
 namespace Symfony\Component\Notifier\Bridge\Bluesky\Tests;
 
 use Symfony\Component\Notifier\Bridge\Bluesky\BlueskyTransportFactory;
-use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
 
-class BlueskyTransportFactoryTest extends TransportFactoryTestCase
+class BlueskyTransportFactoryTest extends AbstractTransportFactoryTestCase
 {
+    use IncompleteDsnTestTrait;
+
     public function createFactory(): BlueskyTransportFactory
     {
         return new BlueskyTransportFactory();

src/Symfony/Component/Notifier/Bridge/Brevo/Tests/BrevoTransportFactoryTest.php

@@ -12,10 +12,15 @@
 namespace Symfony\Component\Notifier\Bridge\Brevo\Tests;
 
 use Symfony\Component\Notifier\Bridge\Brevo\BrevoTransportFactory;
-use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
+use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
+use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
 
-final class BrevoTransportFactoryTest extends TransportFactoryTestCase
+final class BrevoTransportFactoryTest extends AbstractTransportFactoryTestCase
 {
+    use IncompleteDsnTestTrait;
+    use MissingRequiredOptionTestTrait;
+
     public function createFactory(): BrevoTransportFactory
     {
         return new BrevoTransportFactory();

src/Symfony/Component/Notifier/Bridge/Brevo/composer.json

@@ -18,7 +18,7 @@
     "require": {
         "php": ">=8.2",
         "symfony/http-client": "^6.4|^7.0",
-        "symfony/notifier": "^6.4|^7.0"
+        "symfony/notifier": "^7.2"
     },
     "require-dev": {
         "symfony/event-dispatcher": "^5.4|^6.0|^7.0"