feature symfony#50838 [DoctrineBridge] Remove outdated comment (HeahDude)

nicolas-grekas · nicolas-grekas · commit d2fbdc3b0195 · 2023-07-03T14:59:02.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [DoctrineBridge] Remove outdated comment | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ Spotted by `@nicolas`-grekas. To throw a proper exception the method has been kept. No need to keep the comment, and I guess no need to keep it internal. Commits ------- 1f60d2a [DoctrineBridge] Remove outdated comment
diff --git a/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php b/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php
@@ -57,9 +57,6 @@ protected function loadChoices(): iterable
             : $this->manager->getRepository($this->class)->findAll();
     }
 
-    /**
-     * @internal to be remove in Symfony 6
-     */
     protected function doLoadValuesForChoices(array $choices): array
     {
         // Optimize performance for single-field identifiers. We already

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,6 @@ protected function loadChoices(): iterable`
`57`	`57`	`: $this->manager->getRepository($this->class)->findAll();`
`58`	`58`	`}`
`59`	`59`
`60`		`- /**`
`61`		`- * @internal to be remove in Symfony 6`
`62`		`- */`
`63`	`60`	`protected function doLoadValuesForChoices(array $choices): array`
`64`	`61`	`{`
`65`	`62`	`// Optimize performance for single-field identifiers. We already`