minor symfony#57775 [HttpFoundation][HttpKernel] Remove unused code and useless casts (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[HttpFoundation][HttpKernel] Remove unused code and useless casts

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Removed some superfluous code and useless casts across HttpFoundation and HttpKernel

Commits
-------

c26bb3a [HttpFoundation][HttpKernel] Remove dead code and useless casts

Author: fabpot

src/Symfony/Bundle/FrameworkBundle/CacheWarmer/RouterCacheWarmer.php

@@ -43,7 +43,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null): array
         $router = $this->container->get('router');
 
         if ($router instanceof WarmableInterface) {
-            return (array) $router->warmUp($cacheDir, $buildDir);
+            return $router->warmUp($cacheDir, $buildDir);
         }
 
         throw new \LogicException(\sprintf('The router "%s" cannot be warmed up because it does not implement "%s".', get_debug_type($router), WarmableInterface::class));

src/Symfony/Bundle/FrameworkBundle/CacheWarmer/TranslationsCacheWarmer.php

@@ -40,7 +40,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null): array
         $this->translator ??= $this->container->get('translator');
 
         if ($this->translator instanceof WarmableInterface) {
-            return (array) $this->translator->warmUp($cacheDir, $buildDir);
+            return $this->translator->warmUp($cacheDir, $buildDir);
         }
 
         return [];

src/Symfony/Bundle/FrameworkBundle/Tests/CacheWarmer/RouterCacheWarmerTest.php

@@ -24,6 +24,8 @@ public function testWarmUpWithWarmableInterfaceWithBuildDir()
         $container = new Container();
 
         $routerMock = $this->getMockBuilder(testRouterInterfaceWithWarmableInterface::class)->onlyMethods(['match', 'generate', 'getContext', 'setContext', 'getRouteCollection', 'warmUp'])->getMock();
+        $routerMock->method('warmUp')->willReturn([]);
+
         $container->set('router', $routerMock);
         $routerCacheWarmer = new RouterCacheWarmer($container);
 

src/Symfony/Component/HttpFoundation/BinaryFileResponse.php

@@ -70,7 +70,7 @@ public function setFile(\SplFileInfo|string $file, ?string $contentDisposition =
             if ($file instanceof \SplFileInfo) {
                 $file = new File($file->getPathname(), !$isTemporaryFile);
             } else {
-                $file = new File((string) $file);
+                $file = new File($file);
             }
         }
 

src/Symfony/Component/HttpFoundation/File/File.php

@@ -134,8 +134,7 @@ protected function getName(string $name): string
     {
         $originalName = str_replace('\\', '/', $name);
         $pos = strrpos($originalName, '/');
-        $originalName = false === $pos ? $originalName : substr($originalName, $pos + 1);
 
-        return $originalName;
+        return false === $pos ? $originalName : substr($originalName, $pos + 1);
     }
 }

src/Symfony/Component/HttpFoundation/HeaderBag.php

@@ -118,7 +118,7 @@ public function get(string $key, ?string $default = null): ?string
             return null;
         }
 
-        return (string) $headers[0];
+        return $headers[0];
     }
 
     /**

src/Symfony/Component/HttpFoundation/Request.php

@@ -1878,7 +1878,7 @@ protected function preparePathInfo(): string
         }
 
         $pathInfo = substr($requestUri, \strlen($baseUrl));
-        if (false === $pathInfo || '' === $pathInfo) {
+        if ('' === $pathInfo) {
             // If substr() returns false then PATH_INFO is set to an empty string
             return '/';
         }

src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseCookieValueSame.php

@@ -34,9 +34,8 @@ public function toString(): string
         if ($this->domain) {
             $str .= \sprintf(' for domain "%s"', $this->domain);
         }
-        $str .= \sprintf(' with value "%s"', $this->value);
 
-        return $str;
+        return $str.\sprintf(' with value "%s"', $this->value);
     }
 
     /**

src/Symfony/Component/HttpKernel/Attribute/AsController.php

@@ -21,7 +21,4 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_FUNCTION)]
 class AsController
 {
-    public function __construct()
-    {
-    }
 }

src/Symfony/Component/HttpKernel/CacheWarmer/CacheWarmerAggregate.php

@@ -93,7 +93,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null, ?SymfonyStyle
                 }
 
                 $start = microtime(true);
-                foreach ((array) $warmer->warmUp($cacheDir, $buildDir) as $item) {
+                foreach ($warmer->warmUp($cacheDir, $buildDir) as $item) {
                     if (is_dir($item) || (str_starts_with($item, \dirname($cacheDir)) && !is_file($item)) || ($buildDir && str_starts_with($item, \dirname($buildDir)) && !is_file($item))) {
                         throw new \LogicException(\sprintf('"%s::warmUp()" should return a list of files or classes but "%s" is none of them.', $warmer::class, $item));
                     }