[SymForce] Enable ignore-without-code in mypy

Requires ignore codes (e.g. `type: ignore[arg-type]`) for all ignores.

Reviewers: brad,nathan,ryan-b,william-a
Topic: sf-ignore-without-code
GitOrigin-RevId: 7994d17696bc68c8e11816a7580555f84188ce08

Author: aaron-skydio

pyproject.toml

@@ -193,6 +193,8 @@ disallow_untyped_defs = true
 mypy_path = [".", "gen/python", "$SYMFORCE_LCMTYPES_DIR", "symforce/pybind"]
 explicit_package_bases = true
 
+enable_error_code = ["ignore-without-code"]
+
 [[tool.mypy.overrides]]
 module = [
   "IPython.*",

symforce/benchmarks/matrix_multiplication/matrices/fetch_matrices.py

@@ -7,7 +7,7 @@
 Script to download the matrices used for the benchmark into this folder, in Matrix Market format.
 """
 
-import ssgetpy  # type: ignore
+import ssgetpy  # type: ignore[import-not-found]
 
 # Matrix ID's used by the benchmark
 matrices = [449, 1528, 2086, 1920, 1326, 664]

symforce/test_util/epsilon_handling.py

@@ -9,7 +9,7 @@
 
 try:
     # Attempt, works if we're in ipython
-    _default_display_func = display  # type: ignore
+    _default_display_func = display  # type: ignore[name-defined]
 except NameError:
     _default_display_func = print
 

symforce/test_util/random_expressions/unary_binary_expression_gen.py

@@ -166,9 +166,9 @@ def build_tree_sequence(self, num_ops_target: int) -> T.List:
 
             # The annotations in numpy are wrong, and don't include the Sequence[Any] overload
             if arity == 1:
-                op = np.random.choice(self.unary_ops, p=self.unary_ops_probs)  # type: ignore
+                op = np.random.choice(self.unary_ops, p=self.unary_ops_probs)  # type: ignore[arg-type]
             else:
-                op = np.random.choice(self.binary_ops, p=self.binary_ops_probs)  # type: ignore
+                op = np.random.choice(self.binary_ops, p=self.binary_ops_probs)  # type: ignore[arg-type]
 
             e += arity - 1 - k  # created empty nodes - skipped future leaves
             t_leaves += arity - 1  # update number of total leaves

test/geo_matrix_test.py

@@ -383,7 +383,7 @@ def test_multiply_elementwise(self) -> None:
 
         with self.assertRaises(TypeError):
             # This should fail mypy, since it's actually wrong
-            a.multiply_elementwise(sf.M43())  # type: ignore
+            a.multiply_elementwise(sf.M43())  # type: ignore[arg-type]
 
     def test_dot_product(self) -> None:
         """

test/symforce_function_codegen_test_data/symengine/codegen_cpp_test_data/python/lcmtypes/codegen_cpp_test/_constants_t.py

@@ -54,7 +54,7 @@ def __eq__(self, other: object) -> bool:
             (self.epsilon==other.epsilon)
         )
     # Disallow hashing for python struct lcmtypes.
-    __hash__ = None  # type: ignore
+    __hash__ = None  # type: ignore[assignment]
 
     def encode(self) -> bytes:
         buf = BytesIO()

test/symforce_function_codegen_test_data/symengine/codegen_cpp_test_data/python/lcmtypes/codegen_cpp_test/_states_t.py

@@ -55,7 +55,7 @@ def __eq__(self, other: object) -> bool:
             (self.p==other.p)
         )
     # Disallow hashing for python struct lcmtypes.
-    __hash__ = None  # type: ignore
+    __hash__ = None  # type: ignore[assignment]
 
     def encode(self) -> bytes:
         buf = BytesIO()

test/symforce_function_codegen_test_data/symengine/codegen_cpp_test_data/python/lcmtypes/codegen_cpp_test/_values_vec_t.py

@@ -80,7 +80,7 @@ def __eq__(self, other: object) -> bool:
             (self.list_of_lists==other.list_of_lists)
         )
     # Disallow hashing for python struct lcmtypes.
-    __hash__ = None  # type: ignore
+    __hash__ = None  # type: ignore[assignment]
 
     def encode(self) -> bytes:
         buf = BytesIO()

test/symforce_function_codegen_test_data/symengine/codegen_dataclass_in_values_test_data/python/lcmtypes/codegen_test/_my_dataclass_t.py

@@ -55,7 +55,7 @@ def __eq__(self, other: object) -> bool:
             (self.rot==other.rot)
         )
     # Disallow hashing for python struct lcmtypes.
-    __hash__ = None  # type: ignore
+    __hash__ = None  # type: ignore[assignment]
 
     def encode(self) -> bytes:
         buf = BytesIO()

test/symforce_function_codegen_test_data/symengine/codegen_explicit_template_instantiation_test_data/python/lcmtypes/codegen_explicit_template_instantiation_test/_constants_t.py

@@ -54,7 +54,7 @@ def __eq__(self, other: object) -> bool:
             (self.epsilon==other.epsilon)
         )
     # Disallow hashing for python struct lcmtypes.
-    __hash__ = None  # type: ignore
+    __hash__ = None  # type: ignore[assignment]
 
     def encode(self) -> bytes:
         buf = BytesIO()