Commit 98326ab
committed
Add versioned dev_requirements for py 3.8 3.9 3.10
Different version of python have different dev requirements. Previously,
`dev_requirements.txt` was generated for python3.8 and assumed to work
for other versions of python.
That was more or less a safe assumption, except is now causing problems.
Specifically, gtsam is not available on python 3.10, but we'd like to
add it as a dev requirement for python 3.8 and 3.9.
`symforce_requirements_test.py` cannot be run until symforce has been
installed, but one might reasonably want to `pip install -r
dev_requirements.txt` before installing symforce (to use the pinned
build depencies during installation).
To make this circular dependency less painful for the user, I'm adding
- `dev_requirements_38.txt`
- `dev_requirements_39.txt`
- `dev_requirements_310.txt`
so that the correct dev requirements can be installed before symforce
installation for any supported python version.
Modified `test/symforce_requirements_test.py` to only test/update the
`dev_requirements_XY.txt` of the python version being used.
Since the public CI is already running this test, it will guarentee that
none of these files will go out of date.
Needed to amend both ci.yml and docs.yml to use the correct
`dev_requirements_XY.txt`.
Also needed to update the `README.md` accordingly.1 parent 559e521 commit 98326ab
File tree
7 files changed
+760
-11
lines changed- .github/workflows
- test
7 files changed
+760
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
91 | | - | |
92 | | - | |
| 90 | + | |
93 | 91 | | |
94 | 92 | | |
95 | 93 | | |
96 | 94 | | |
97 | | - | |
98 | 95 | | |
99 | 96 | | |
100 | 97 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
565 | 565 | | |
566 | 566 | | |
567 | 567 | | |
568 | | - | |
| 568 | + | |
569 | 569 | | |
570 | 570 | | |
571 | 571 | | |
| |||
574 | 574 | | |
575 | 575 | | |
576 | 576 | | |
577 | | - | |
| 577 | + | |
578 | 578 | | |
| 579 | + | |
579 | 580 | | |
580 | 581 | | |
581 | 582 | | |
| |||
0 commit comments