Skip to content

Commit 96f6eda

Browse files
authored
Remove NewlineServiceDefinitionConfigFixer, as already handled by fluent newliner (#16)
1 parent a52709d commit 96f6eda

File tree

10 files changed

+1
-353
lines changed

10 files changed

+1
-353
lines changed

config/symplify.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
use Symplify\CodingStandard\Fixer\Commenting\RemoveUselessDefaultCommentFixer;
1010
use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
1111
use Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer;
12-
use Symplify\CodingStandard\Fixer\Spacing\NewlineServiceDefinitionConfigFixer;
1312
use Symplify\CodingStandard\Fixer\Spacing\SpaceAfterCommaHereNowDocFixer;
1413
use Symplify\CodingStandard\Fixer\Spacing\StandaloneLinePromotedPropertyFixer;
1514
use Symplify\CodingStandard\Fixer\Strict\BlankLineAfterStrictTypesFixer;
@@ -33,7 +32,6 @@
3332

3433
// newlines
3534
MethodChainingNewlineFixer::class,
36-
NewlineServiceDefinitionConfigFixer::class,
3735
SpaceAfterCommaHereNowDocFixer::class,
3836
BlankLineAfterStrictTypesFixer::class,
3937

docs/rules_overview.md

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 14 Rules Overview
1+
# 13 Rules Overview
22

33
## ArrayListItemNewlineFixer
44

@@ -136,26 +136,6 @@ Each chain method call must be on own line
136136

137137
<br>
138138

139-
## NewlineServiceDefinitionConfigFixer
140-
141-
Add newline for a fluent call on service definition in Symfony config
142-
143-
- class: [`Symplify\CodingStandard\Fixer\Spacing\NewlineServiceDefinitionConfigFixer`](../src/Fixer/Spacing/NewlineServiceDefinitionConfigFixer.php)
144-
145-
```diff
146-
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
147-
use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
148-
149-
return static function (ContainerConfigurator $containerConfigurator): void {
150-
$services = $containerConfigurator->services();
151-
- $services->set(LineLengthFixer::class)->call('configure', [['values']]);
152-
+ $services->set(LineLengthFixer::class)
153-
+ ->call('configure', [['values']]);
154-
};
155-
```
156-
157-
<br>
158-
159139
## ParamReturnAndVarTagMalformsFixer
160140

161141
Fixes @param, @return, `@var` and inline `@var` annotations broken formats

src/Fixer/Spacing/NewlineServiceDefinitionConfigFixer.php

Lines changed: 0 additions & 170 deletions
This file was deleted.

src/TokenAnalyzer/SymfonyClosureAnalyzer.php

Lines changed: 0 additions & 47 deletions
This file was deleted.

tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/many_methods.php.inc

Lines changed: 0 additions & 26 deletions
This file was deleted.

tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/skip_already_newlined.php.inc

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/skip_not_config_call.php.inc

Lines changed: 0 additions & 14 deletions
This file was deleted.

tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/wrong.php.inc

Lines changed: 0 additions & 24 deletions
This file was deleted.

tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/NewlineServiceDefinitionConfigFixerTest.php

Lines changed: 0 additions & 29 deletions
This file was deleted.

tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/config/configured_rule.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)