Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented May 13, 2025

No description provided.

@TomasVotruba TomasVotruba changed the title tv return variable name [Annotation] Add RemovePropertyVariableNameDescriptionFixer May 13, 2025
@TomasVotruba TomasVotruba force-pushed the tv-return-variable-name branch from b8b73be to fe3f2bf Compare May 13, 2025 12:58
@TomasVotruba TomasVotruba force-pushed the tv-return-variable-name branch from fe3f2bf to ba4b30a Compare May 13, 2025 12:59
@TomasVotruba TomasVotruba enabled auto-merge (squash) May 13, 2025 12:59
@TomasVotruba TomasVotruba merged commit 53fa635 into main May 13, 2025
6 checks passed
@TomasVotruba TomasVotruba deleted the tv-return-variable-name branch May 13, 2025 12:59
@samsonasik
Copy link
Member

It seems have bug on multiple @var on variable defintiion on single comment.

            /**
             * @var FuncCall $firstArgumentValue
             * @var array<Arg> $args
             **/
            $args = $firstArgumentValue->getArgs();

cause:

1) rules/CodeQuality/Rector/MethodCall/AssertTrueFalseToSpecificMethodRector.php

    ---------- begin diff ----------
@@ -106,7 +106,7 @@
         if ($firstArgumentName === 'is_a') {
             /**
              * @var FuncCall $firstArgumentValue
-             * @var array<Arg> $args
+             * @var array<Arg>
              **/
             $args = $firstArgumentValue->getArgs();

I will look into it.

@samsonasik
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants