Bump to PHPStan ^2.1.32 with fix ClassConstFetchReturnTypeResolver

samsonasik · samsonasik · commit c1f7c36eb380 · 2025-11-12T23:37:57.000+07:00
diff --git a/composer.json b/composer.json
@@ -5,7 +5,7 @@
     "license": "MIT",
     "require": {
         "php": ">=8.2",
-        "phpstan/phpstan": "^2.1"
+        "phpstan/phpstan": "^2.1.32"
     },
     "require-dev": {
         "illuminate/container": "^11.0",
diff --git a/src/TypeResolver/ClassConstFetchReturnTypeResolver.php b/src/TypeResolver/ClassConstFetchReturnTypeResolver.php
@@ -13,14 +13,13 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
-use Symplify\PHPStanExtensions\Exception\ShouldNotHappenException;
 
 final class ClassConstFetchReturnTypeResolver
 {
     public function resolve(MethodReflection $methodReflection, MethodCall $methodCall): ?Type
     {
         if (! isset($methodCall->args[0])) {
-            throw new ShouldNotHappenException('Not supported without argument');
+            return null;
         }
 
         $firstArgOrVariadciPlaceholder = $methodCall->args[0];

Original file line number	Diff line number	Diff line change
`@@ -13,14 +13,13 @@`
`13`	`13`	`use PHPStan\Type\MixedType;`
`14`	`14`	`use PHPStan\Type\ObjectType;`
`15`	`15`	`use PHPStan\Type\Type;`
`16`		`-use Symplify\PHPStanExtensions\Exception\ShouldNotHappenException;`
`17`	`16`
`18`	`17`	`final class ClassConstFetchReturnTypeResolver`
`19`	`18`	`{`
`20`	`19`	`public function resolve(MethodReflection $methodReflection, MethodCall $methodCall): ?Type`
`21`	`20`	`{`
`22`	`21`	`if (! isset($methodCall->args[0])) {`
`23`		`- throw new ShouldNotHappenException('Not supported without argument');`
	`22`	`+ return null;`
`24`	`23`	`}`
`25`	`24`
`26`	`25`	`$firstArgOrVariadciPlaceholder = $methodCall->args[0];`