[symfony] kick of require is granted rule

Author: TomasVotruba

config/symfony-rules.neon

@@ -23,3 +23,6 @@ rules:
     - Symplify\PHPStanRules\Rules\Symfony\SingleRequiredMethodRule
     - Symplify\PHPStanRules\Rules\Symfony\RequiredOnlyInAbstractRule
     - Symplify\PHPStanRules\Rules\Symfony\NoConstructorAndRequiredTogetherRule
+
+    # attributes
+    - Symplify\PHPStanRules\Rules\Symfony\RequireIsGrantedEnumRule

src/Rules/Doctrine/NoDocumentMockingRule.php

@@ -6,7 +6,6 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;

src/Rules/Doctrine/NoGetRepositoryOnServiceRepositoryEntityRule.php

@@ -7,7 +7,6 @@
 use Nette\Utils\Strings;
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ReflectionProvider;

src/Rules/Symfony/NoFindTaggedServiceIdsCallRule.php

@@ -6,7 +6,6 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\Rule;

src/Rules/Symfony/RequireIsGrantedEnumRule.php

@@ -0,0 +1,44 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Rules\Symfony;
+
+use PhpParser\Node;
+use PhpParser\Node\Attribute;
+use PhpParser\Node\Scalar\String_;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
+
+final class RequireIsGrantedEnumRule implements Rule
+{
+    public function getNodeType(): string
+    {
+        return Attribute::class;
+    }
+
+    /**
+     * @param Attribute $node
+     */
+    public function processNode(Node $node, Scope $scope): array
+    {
+        if ($node->name->toString() !== IsGranted::class) {
+            return [];
+        }
+
+        $isGrantedExpr = $node->args[0]->value;
+        if (! $isGrantedExpr instanceof String_) {
+            return [];
+        }
+
+        return [
+            RuleErrorBuilder::message(
+                sprintf('Instead of "%s" string, use enum constant for #[IsGranted]', $isGrantedExpr->value)
+            )
+                ->identifier('symfony.requiredIsGrantedEnum')
+                ->build(),
+        ];
+    }
+}

src/TypeAnalyzer/CallableTypeAnalyzer.php

@@ -6,8 +6,6 @@
 
 use PhpParser\Node\Expr;
 use PHPStan\Analyser\Scope;
-use PHPStan\Type\CallableType;
-use PHPStan\Type\ClosureType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;