Add support #[AsEventListener] for NoListenerWithoutContractRule (#193)

* Add support `#[AsEventListener]` for `NoListenerWithoutContractRule`

* Revert fixture file

---------

Co-authored-by: Tomas Votruba <[email protected]>

Author: Myks92

README.md

@@ -1667,7 +1667,7 @@ final class SomeClass
 
 ### NoListenerWithoutContractRule
 
-There should be no listeners modified in config. Use EventSubscriberInterface contract and PHP instead
+There should be no listeners modified in config. Use EventSubscriberInterface contract or #[AsEventListener] attribute and PHP instead
 
 ```yaml
 rules:
@@ -1709,6 +1709,22 @@ class SomeListener implements EventSubscriberInterface
 
 <br>
 
+```php
+use Symfony\Component\EventDispatcher\Attribute\AsEventListener;
+
+#[AsEventListener]
+class SomeListener
+{
+    public function __invoke()
+    {
+    }
+}
+```
+
+:+1:
+
+<br>
+
 ### NoStringInGetSubscribedEventsRule
 
 Symfony getSubscribedEvents() method must contain only event class references, no strings

src/Enum/SymfonyClass.php

@@ -19,6 +19,8 @@ final class SymfonyClass
 
     public const ABSTRACT_CONTROLLER = 'Symfony\Bundle\FrameworkBundle\Controller\AbstractController';
 
+    public const EVENT_LISTENER_ATTRIBUTE = 'Symfony\Component\EventDispatcher\Attribute\AsEventListener';
+
     public const EVENT_SUBSCRIBER_INTERFACE = 'Symfony\Component\EventDispatcher\EventSubscriberInterface';
 
     public const EVENT_DISPATCHER_INTERFACE = 'Symfony\Component\EventDispatcher\EventDispatcherInterface';

src/Rules/Symfony/NoListenerWithoutContractRule.php

@@ -10,6 +10,7 @@
 use PHPStan\Node\InClassNode;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use Symplify\PHPStanRules\Enum\SymfonyClass;
 use Symplify\PHPStanRules\Enum\SymfonyRuleIdentifier;
 
 /**
@@ -25,7 +26,7 @@ final class NoListenerWithoutContractRule implements Rule
     /**
      * @var string
      */
-    public const ERROR_MESSAGE = 'There should be no listeners modified in config. Use EventSubscriberInterface contract and PHP instead';
+    public const ERROR_MESSAGE = 'There should be no listeners modified in config. Use EventSubscriberInterface contract or #[AsEventListener] attribute and PHP instead ';
 
     /**
      * @see https://www.doctrine-project.org/projects/doctrine-orm/en/3.3/reference/events.html
@@ -78,6 +79,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        if ($this->isAttributeListener($classLike)) {
+            return [];
+        }
+
         $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(SymfonyRuleIdentifier::NO_LISTENER_WITHOUT_CONTRACT)
             ->build();
@@ -96,4 +101,17 @@ private function isDoctrineListener(Class_ $class): bool
 
         return false;
     }
+
+    private function isAttributeListener(Class_ $class): bool
+    {
+        foreach ($class->attrGroups as $attrGroup) {
+            foreach ($attrGroup->attrs as $attr) {
+                if ($attr->name->toString() === SymfonyClass::EVENT_LISTENER_ATTRIBUTE) {
+                    return true;
+                }
+            }
+        }
+
+        return false;
+    }
 }

tests/Rules/Symfony/NoListenerWithoutContractRule/Fixture/SomeContractedWithAttributeListener.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Symplify\PHPStanRules\Tests\Rules\Symfony\NoListenerWithoutContractRule\Fixture;
+
+use Symfony\Component\EventDispatcher\Attribute\AsEventListener;
+
+#[AsEventListener]
+final class SomeContractedWithAttributeListener
+{
+}

tests/Rules/Symfony/NoListenerWithoutContractRule/NoListenerWithoutContractRuleTest.php

@@ -22,6 +22,7 @@ public function testRule(array $filePaths, array $expectedErrorsWithLines): void
     public static function provideData(): Iterator
     {
         yield [[__DIR__ . '/Fixture/SomeContractedListener.php'], []];
+        yield [[__DIR__ . '/Fixture/SomeContractedWithAttributeListener.php'], []];
         yield [[__DIR__ . '/Fixture/SkipDoctrineListener.php'], []];
 
         yield [[__DIR__ . '/Fixture/SomeBareListener.php'], [[