README

Author: TomasVotruba

README.md

@@ -1438,6 +1438,49 @@ rules:
 <br>
 
 
+### TaggedIteratorOverRepeatedServiceCallRuleTest
+
+Instead of repeated "->call(%s, ...)" calls, pass services as tagged iterator argument to the constructor
+
+```yaml
+rules:
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\TaggedIteratorOverRepeatedServiceCallRule
+```
+
+```php
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ref;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->set(SomeService::class)
+        ->call('setService', [ref('service1')])
+        ->call('setService', [ref('service2')])
+        ->call('setService', [ref('service3')]);
+};
+```
+
+:x:
+
+<br>
+
+```php
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use Symfony\Component\DependencyInjection\Loader\Configurator\tagged_iterator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->set(SomeService::class)
+        ->arg('$services', tagged_iterator('SomeServiceTag'));
+};
+```
+
+:+1:
+
+<br>
+
 ### NoGetInCommandRule
 
 Prevents using `$this->get(...)` in commands, to promote dependency injection.

src/Enum/SymfonyFunctionName.php

@@ -6,7 +6,7 @@
 
 final class SymfonyFunctionName
 {
-    public const REFERENCE = 'Symfony\Component\DependencyInjection\Loader\Configurator\reference';
+    public const REFERENCE = 'Symfony\Component\DependencyInjection\Loader\Configurator\ref';
 
     public const SERVICE = 'Symfony\Component\DependencyInjection\Loader\Configurator\service';
 }

src/Symfony/NodeFinder/RepeatedServiceAdderCallNameFinder.php

@@ -66,7 +66,7 @@ private static function findCallMethodCalls(MethodCall $methodCall): array
         $nodeFinder = new NodeFinder();
 
         /** @var MethodCall[] $callMethodCalls */
-        $callMethodCalls = $nodeFinder->find($methodCall, function (Node $node) {
+        $callMethodCalls = $nodeFinder->find($methodCall, function (Node $node): bool {
             if (! $node instanceof MethodCall) {
                 return false;
             }