skip magic methods in NoDynamicNameRule, as dynamic name expected there (#256)

Author: TomasVotruba

src/Rules/NoDynamicNameRule.php

@@ -65,6 +65,10 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         if ($node instanceof MethodCall || $node instanceof StaticCall || $node instanceof FuncCall || $node instanceof PropertyFetch) {
+            // skip magic calls, as dynamic names expected
+            if (in_array($scope->getFunctionName(), ['__get', '__set'], true)) {
+                return [];
+            }
 
             if (! $node->name instanceof Expr) {
                 return [];

tests/Rules/NoDynamicNameRule/Fixture/SkipMagicGet.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoDynamicNameRule\Fixture;
+
+final class SkipMagicGet
+{
+    public function __get($name)
+    {
+        return $this->{$name};
+    }
+}

tests/Rules/NoDynamicNameRule/NoDynamicNameRuleTest.php

@@ -38,6 +38,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipInvokable.php', []];
         yield [__DIR__ . '/Fixture/SkipClosure.php', []];
         yield [__DIR__ . '/Fixture/SkipCallable.php', []];
+        yield [__DIR__ . '/Fixture/SkipMagicGet.php', []];
         yield [__DIR__ . '/Fixture/SkipCallableUnion.php', []];
         yield [__DIR__ . '/Fixture/SkipNullableClosure.php', []];
         yield [__DIR__ . '/Fixture/SkipImmediatelyInvokedFunctionExpression.php', []];