[symfony] Add NoDuplicateArg(s)AutowireByTypeRule, and NoServiceSameNameSetClassRule (#210)

* [symfony] Add NoDuplicateArgAutowireByTypeRule

* [symfony] Add NoServiceSameNameSetClassRule

* README

Author: TomasVotruba

README.md

@@ -1493,6 +1493,81 @@ rules:
 
 <br>
 
+### NoServiceSameNameSetClassRule
+
+No need to duplicate service class and name. Use only "$services->set(%s::class)" instead
+
+```yaml
+rules:
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoServiceSameNameSetClassRule
+```
+
+```php
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->set(SomeService::class, SomeService::class);
+};
+```
+
+:x:
+
+<br>
+
+```php
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->set(SomeService::class);
+};
+```
+
+<br>
+
+### NoDuplicateArgsAutowireByTypeRule
+
+Instead of passing "%s" to args(), remove the line and let autowiring handle it
+
+```yaml
+rules:
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoDuplicateArgAutowireByTypeRule
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoDuplicateArgsAutowireByTypeRule
+```
+
+```php
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->set(SomeService::class)
+        ->args([
+            ref(SomeService::class),
+        ]);
+};
+```
+
+:x:
+
+<br>
+
+```php
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->set(SomeService::class);
+};
+```
+
+:+1:
+
+<br>
 
 ### NoAbstractControllerConstructorRule
 

config/services/services.neon

@@ -25,6 +25,9 @@ services:
     # doctrine
     - Symplify\PHPStanRules\Doctrine\DoctrineEntityDocumentAnalyser
 
+    # symfony
+    - Symplify\PHPStanRules\Symfony\Reflection\ClassConstructorTypesResolver
+
     # rules enabled by configuration
     -
         class: Symplify\PHPStanRules\Rules\MaximumIgnoredErrorCountRule

config/symfony-config-rules.neon

@@ -3,3 +3,10 @@ rules:
     - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoBundleResourceConfigRule
     - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\AlreadyRegisteredAutodiscoveryServiceRule
     - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\TaggedIteratorOverRepeatedServiceCallRule
+
+    # args() and arg() call
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoDuplicateArgsAutowireByTypeRule
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoDuplicateArgAutowireByTypeRule
+
+    # $services->set('X', 'X')
+    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoServiceSameNameSetClassRule

src/Enum/DoctrineRuleIdentifier.php …uleIdentifier/DoctrineRuleIdentifier.phpsrc/Enum/DoctrineRuleIdentifier.php renamed to src/Enum/RuleIdentifier/DoctrineRuleIdentifier.php src/Enum/DoctrineRuleIdentifier.php renamed to src/Enum/RuleIdentifier/DoctrineRuleIdentifier.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Symplify\PHPStanRules\Enum;
+namespace Symplify\PHPStanRules\Enum\RuleIdentifier;
 
 final class DoctrineRuleIdentifier
 {

src/Enum/PHPUnitRuleIdentifier.php …RuleIdentifier/PHPUnitRuleIdentifier.phpsrc/Enum/PHPUnitRuleIdentifier.php renamed to src/Enum/RuleIdentifier/PHPUnitRuleIdentifier.php src/Enum/PHPUnitRuleIdentifier.php renamed to src/Enum/RuleIdentifier/PHPUnitRuleIdentifier.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Symplify\PHPStanRules\Enum;
+namespace Symplify\PHPStanRules\Enum\RuleIdentifier;
 
 final class PHPUnitRuleIdentifier
 {

src/Enum/RectorRuleIdentifier.php …/RuleIdentifier/RectorRuleIdentifier.phpsrc/Enum/RectorRuleIdentifier.php renamed to src/Enum/RuleIdentifier/RectorRuleIdentifier.php src/Enum/RectorRuleIdentifier.php renamed to src/Enum/RuleIdentifier/RectorRuleIdentifier.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Symplify\PHPStanRules\Enum;
+namespace Symplify\PHPStanRules\Enum\RuleIdentifier;
 
 final class RectorRuleIdentifier
 {

src/Enum/SymfonyRuleIdentifier.php …RuleIdentifier/SymfonyRuleIdentifier.phpsrc/Enum/SymfonyRuleIdentifier.php renamed to src/Enum/RuleIdentifier/SymfonyRuleIdentifier.php src/Enum/SymfonyRuleIdentifier.php renamed to src/Enum/RuleIdentifier/SymfonyRuleIdentifier.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Symplify\PHPStanRules\Enum;
+namespace Symplify\PHPStanRules\Enum\RuleIdentifier;
 
 final class SymfonyRuleIdentifier
 {
@@ -47,4 +47,10 @@ final class SymfonyRuleIdentifier
     public const NO_BUNDLE_RESOURCE_CONFIG = 'symfony.noBundleResourceConfig';
 
     public const ALREADY_REGISTERED_AUTODISCOVERY_SERVICE = 'symfony.alreadyRegisteredAutodiscoveryService';
+
+    public const NO_DUPLICATE_ARGS_AUTOWIRE_BY_TYPE = 'symfony.noDuplicateArgsAutowireByType';
+
+    public const NO_DUPLICATE_ARG_AUTOWIRE_BY_TYPE = 'symfony.noDuplicateArgAutowireByType';
+
+    public const NO_SERVICE_SAME_NAME_SET_CLASS = 'symfony.noServiceSameNameSetClass';
 }

src/Enum/SymfonyFunctionName.php

@@ -6,7 +6,7 @@
 
 final class SymfonyFunctionName
 {
-    public const REFERENCE = 'Symfony\Component\DependencyInjection\Loader\Configurator\ref';
+    public const REF = 'Symfony\Component\DependencyInjection\Loader\Configurator\ref';
 
     public const SERVICE = 'Symfony\Component\DependencyInjection\Loader\Configurator\service';
 }

src/Helper/NamingHelper.php

@@ -0,0 +1,44 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Helper;
+
+use PhpParser\Node;
+use PhpParser\Node\Identifier;
+use PhpParser\Node\Name;
+
+final class NamingHelper
+{
+    public static function getName(Node $node): ?string
+    {
+        if ($node instanceof Identifier || $node instanceof Name) {
+            return $node->toString();
+        }
+
+        return null;
+    }
+
+    public static function isName(Node $node, string $name): bool
+    {
+        if ($node instanceof Identifier || $node instanceof Name) {
+            return $node->toString() === $name;
+        }
+
+        return false;
+    }
+
+    /**
+     * @param string[] $names
+     */
+    public static function isNames(Node $node, array $names): bool
+    {
+        foreach ($names as $name) {
+            if (self::isName($node, $name)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+}

src/Rules/Doctrine/NoDoctrineListenerWithoutContractRule.php

@@ -11,7 +11,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Doctrine\DoctrineEventSubscriberAnalyzer;
-use Symplify\PHPStanRules\Enum\DoctrineRuleIdentifier;
+use Symplify\PHPStanRules\Enum\RuleIdentifier\DoctrineRuleIdentifier;
 
 /**
  * Based on https://tomasvotruba.com/blog/2019/07/22/how-to-convert-listeners-to-subscribers-and-reduce-your-configs