handle cases, if int is returned in nested call in NoIntegerRefactorReturnRule (#250)

Author: TomasVotruba

src/Rules/Rector/NoIntegerRefactorReturnRule.php

@@ -65,7 +65,7 @@ public function processNode(Node $node, Scope $scope): array
             $constantNames = $this->findUsedNodeVisitorConstantNames($node);
 
             $undesiredConstantNames = array_diff($constantNames, ['REMOVE_NODE']);
-            if ($undesiredConstantNames === []) {
+            if ($constantNames !== [] && $undesiredConstantNames === []) {
                 return [];
             }
 

tests/Rules/Rector/NoIntegerRefactorReturnRule/Fixture/NestedReturnInt.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Rector\NoIntegerRefactorReturnRule\Fixture;
+
+use PhpParser\Node;
+use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\Interface_;
+use PhpParser\NodeVisitor;
+use Rector\Rector\AbstractRector;
+
+final class NestedReturnInt extends AbstractRector
+{
+    public function getNodeTypes(): array
+    {
+        return [Class_::class, Interface_::class];
+    }
+
+    public function refactor(Node $node): \PhpParser\Node|int
+    {
+        if ($node instanceof Class_) {
+            return $node;
+        }
+
+        return $this->getDontTraverseChildren();
+    }
+
+    private function getDontTraverseChildren(): int
+    {
+        return NodeVisitor::DONT_TRAVERSE_CHILDREN;
+    }
+}

tests/Rules/Rector/NoIntegerRefactorReturnRule/NoIntegerRefactorReturnRuleTest.php

@@ -22,6 +22,9 @@ public static function provideData(): Iterator
         $errorMessage = NoIntegerRefactorReturnRule::ERROR_MESSAGE;
         yield [__DIR__ . '/Fixture/SimpleReturnInt.php', [[$errorMessage, 20]]];
 
+        $errorMessage = NoIntegerRefactorReturnRule::ERROR_MESSAGE;
+        yield [__DIR__ . '/Fixture/NestedReturnInt.php', [[$errorMessage, 20]]];
+
         yield [__DIR__ . '/Fixture/SkipBareNodeReturn.php', []];
         yield [__DIR__ . '/Fixture/AllowRemoveNode.php', []];
         yield [__DIR__ . '/Fixture/AllowNestedClosure.php', []];