skip NoMockOnlyTestRule if non mock class properties found (#183)

Author: TomasVotruba

src/Rules/PHPUnit/NoMockOnlyTestRule.php

@@ -51,6 +51,7 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         $hasExclusivelyMockedProperties = true;
+        $hasSomeProperties = false;
 
         foreach ($classLike->getProperties() as $property) {
             if (! $property->type instanceof Name) {
@@ -61,10 +62,12 @@ public function processNode(Node $node, Scope $scope): array
 
             if ($propertyClassName !== ClassName::MOCK_OBJECT_CLASS) {
                 $hasExclusivelyMockedProperties = false;
+            } else {
+                $hasSomeProperties = true;
             }
         }
 
-        if ($hasExclusivelyMockedProperties === false) {
+        if ($hasExclusivelyMockedProperties === false || $hasSomeProperties === false) {
             return [];
         }
 

tests/Rules/PHPUnit/NoMockOnlyTestRule/Fixture/SkipSoleProperty.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Symplify\PHPStanRules\Tests\Rules\PHPUnit\NoMockOnlyTestRule\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SkipSoleProperty extends TestCase
+{
+    private array $someItems = [];
+}

tests/Rules/PHPUnit/NoMockOnlyTestRule/NoMockOnlyTestRuleTest.php

@@ -27,6 +27,7 @@ public static function provideData(): Iterator
 
         yield [__DIR__ . '/Fixture/SkipTestWithClass.php', []];
         yield [__DIR__ . '/Fixture/SkipNoProperty.php', []];
+        yield [__DIR__ . '/Fixture/SkipSoleProperty.php', []];
     }
 
     protected function getRule(): Rule