Remove CheckClassNamespaceFollowPsr4Rule as overly detailed, use composer-dependency-analyser instead (#150)

* Remove CheckClassNamespaceFollowPsr4Rule as overly detailed, use composer-dependency-analyser instead

* update rector config, bump to PHP 8.2

Author: TomasVotruba

README.md

@@ -108,38 +108,6 @@ class SomeClass
 
 <br>
 
-## CheckClassNamespaceFollowPsr4Rule
-
-Class like namespace "%s" does not follow PSR-4 configuration in `composer.json`
-
-- class: [`Symplify\PHPStanRules\Rules\CheckClassNamespaceFollowPsr4Rule`](../src/Rules/CheckClassNamespaceFollowPsr4Rule.php)
-
-```php
-// defined "Foo\Bar" namespace in composer.json > autoload > psr-4
-namespace Foo;
-
-class Baz
-{
-}
-```
-
-:x:
-
-<br>
-
-```php
-// defined "Foo\Bar" namespace in composer.json > autoload > psr-4
-namespace Foo\Bar;
-
-class Baz
-{
-}
-```
-
-:+1:
-
-<br>
-
 ## CheckRequiredInterfaceInContractNamespaceRule
 
 Interface must be located in "Contract" or "Contracts" namespace

config/naming-rules.neon

@@ -3,4 +3,3 @@ rules:
     - Symplify\PHPStanRules\Rules\NoReturnSetterMethodRule
     - Symplify\PHPStanRules\Rules\UppercaseConstantRule
     - Symplify\PHPStanRules\Rules\ClassNameRespectsParentSuffixRule
-    - Symplify\PHPStanRules\Rules\CheckClassNamespaceFollowPsr4Rule

config/services/services.neon

@@ -5,11 +5,7 @@ services:
     - Symplify\PHPStanRules\Matcher\ArrayStringAndFnMatcher
     - Symplify\PHPStanRules\NodeFinder\TypeAwareNodeFinder
     - Symplify\PHPStanRules\PhpDoc\SeePhpDocTagNodesFinder
-    - Symplify\PHPStanRules\Composer\ClassNamespaceMatcher
-    - Symplify\PHPStanRules\Composer\ComposerAutoloadResolver
-    - Symplify\PHPStanRules\Composer\Psr4PathValidator
     - Symplify\PHPStanRules\Formatter\RequiredWithMessageFormatter
-    - Symplify\PHPStanRules\Location\DirectoryChecker
     - Symplify\PHPStanRules\Naming\ClassToSuffixResolver
     - Symplify\PHPStanRules\NodeAnalyzer\AttributeFinder
     - Symplify\PHPStanRules\NodeAnalyzer\EnumAnalyzer

rector.php

@@ -3,44 +3,19 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\PHPUnit\Set\PHPUnitSetList;
-use Rector\Set\ValueObject\LevelSetList;
-use Rector\Set\ValueObject\SetList;
-
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->sets([
-        PHPUnitSetList::PHPUNIT_100,
-        SetList::CODE_QUALITY,
-        SetList::DEAD_CODE,
-        LevelSetList::UP_TO_PHP_81,
-        SetList::CODING_STYLE,
-        SetList::TYPE_DECLARATION,
-        SetList::NAMING,
-        SetList::PRIVATIZATION,
-        SetList::EARLY_RETURN,
-        PHPUnitSetList::PHPUNIT_CODE_QUALITY,
-    ]);
-
-    $rectorConfig->paths([
-        __DIR__ . '/config',
-        __DIR__ . '/src',
-        __DIR__ . '/tests',
-    ]);
-
-    $rectorConfig->importNames();
-
-    $rectorConfig->skip([
+use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
+
+return RectorConfig::configure()
+    ->withPhpSets()
+    ->withPreparedSets(codeQuality: true, deadCode: true, codingStyle: true, typeDeclarations: true, naming: true, privatization: true, earlyReturn: true, phpunitCodeQuality: true)
+    ->withPaths([__DIR__ . '/config', __DIR__ . '/src', __DIR__ . '/tests'])
+    ->withRootFiles()
+    ->withImportNames()
+    ->withSkip([
         '*/Source/*',
         '*/Fixture/*',
-
-        \Rector\Php55\Rector\String_\StringClassNameToClassConstantRector::class => [
+        StringClassNameToClassConstantRector::class => [
             __DIR__ . '/tests/Naming/ClassToSuffixResolverTest.php',
             __DIR__ . '/tests/Rules/Rector/PhpUpgradeImplementsMinPhpVersionInterfaceRule/PhpUpgradeImplementsMinPhpVersionInterfaceRuleTest.php',
         ],
     ]);
-
-    $rectorConfig->ruleWithConfiguration(\Rector\Php55\Rector\String_\StringClassNameToClassConstantRector::class, [
-        'Symfony\Component\Console\*',
-        'Rector\Contract\Rector\ConfigurableRectorInterface',
-    ]);
-};

src/Composer/ClassNamespaceMatcher.php

@@ -12,10 +12,10 @@
 use PHPStan\Reflection\ClassReflection;
 use Symplify\PHPStanRules\PhpDoc\BarePhpDocParser;
 
-final class EnumAnalyzer
+final readonly class EnumAnalyzer
 {
     public function __construct(
-        private readonly BarePhpDocParser $barePhpDocParser
+        private BarePhpDocParser $barePhpDocParser
     ) {
     }
 

src/Composer/ComposerAutoloadResolver.php

@@ -10,9 +10,9 @@
 /**
  * @todo remove after https://github.com/nikic/PHP-Parser/pull/869 is released
  */
-final class TypeAwareNodeFinder
+final readonly class TypeAwareNodeFinder
 {
-    private readonly NodeFinder $nodeFinder;
+    private NodeFinder $nodeFinder;
 
     public function __construct()
     {