Change NoReturnArrayVariableListRule to ignore array spreads (#139)

Author: carlos-granados

src/Rules/NoReturnArrayVariableListRule.php

@@ -156,6 +156,10 @@ private function resolveExprCount(Array_ $array): int
                 continue;
             }
 
+            if ($item->unpack === true) {
+                continue;
+            }
+
             ++$exprCount;
         }
 

tests/Rules/NoReturnArrayVariableListRule/Fixture/SkipArraySpreads.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoReturnArrayVariableListRule\Fixture;
+
+final class SkipArraySpreads
+{
+    public function run($value)
+    {
+        $a = [1, 2, 3];
+        $b = [4, 5, 6];
+        return [...$a, ...$b];
+    }
+}
+

tests/Rules/NoReturnArrayVariableListRule/NoReturnArrayVariableListRuleTest.php

@@ -30,6 +30,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipNews.php', []];
         yield [__DIR__ . '/Fixture/ValueObject/SkipValueObject.php', []];
         yield [__DIR__ . '/Fixture/SkipParentMethod.php', []];
+        yield [__DIR__ . '/Fixture/SkipArraySpreads.php', []];
     }
 
     /**