Skip to content

Commit 66b658e

Browse files
committed
fixup! Make rules use RuleErrorBuilder
1 parent 78679b7 commit 66b658e

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

src/Rules/NoReferenceRule.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace Symplify\PHPStanRules\Rules;
66

7+
use PHPStan\Rules\RuleError;
78
use PhpParser\Node;
89
use PhpParser\Node\Arg;
910
use PhpParser\Node\Expr\ArrayItem;
@@ -67,7 +68,7 @@ public function process(Node $node, Scope $scope): array
6768
$errorMessages = array_merge($errorMessages, $paramErrorMessage);
6869

6970
return array_map(
70-
static fn ($message) => RuleErrorBuilder::message($message)->build(),
71+
static fn ($message): RuleError => RuleErrorBuilder::message($message)->build(),
7172
array_unique($errorMessages),
7273
);
7374
}

src/Rules/NoReturnArrayVariableListRule.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ private function resolveExprCount(Array_ $array): int
154154
continue;
155155
}
156156

157-
if ($item->unpack === true) {
157+
if ($item->unpack) {
158158
continue;
159159
}
160160

src/Rules/Rector/RequireAssertConfigureValueObjectRectorRule.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,16 +102,16 @@ private function hasArrayObjectTypeParam(ClassMethod $classMethod, ClassReflecti
102102
return false;
103103
}
104104

105-
foreach ($extendedMethodReflection->getVariants() as $parametersAcceptorWithPhpDoc) {
106-
if (! $parametersAcceptorWithPhpDoc instanceof FunctionVariantWithPhpDocs) {
105+
foreach ($extendedMethodReflection->getVariants() as $variant) {
106+
if (! $variant instanceof FunctionVariantWithPhpDocs) {
107107
continue;
108108
}
109109

110-
if ($parametersAcceptorWithPhpDoc->getParameters() === []) {
110+
if ($variant->getParameters() === []) {
111111
continue;
112112
}
113113

114-
$configurationParameterReflection = $parametersAcceptorWithPhpDoc->getParameters()[0];
114+
$configurationParameterReflection = $variant->getParameters()[0];
115115
$phpDocType = $configurationParameterReflection->getPhpDocType();
116116
if (! $phpDocType instanceof ArrayType) {
117117
continue;

0 commit comments

Comments
 (0)